From: Benjamin Herrenschmidt <benh@au1.ibm.com>
To: Wei Yang <weiyang@linux.vnet.ibm.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
gwshan@linux.vnet.ibm.com, linux-pci@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v12 14/21] powerpc/powernv: Allocate struct pnv_ioda_pe iommu_table dynamically
Date: Mon, 02 Mar 2015 18:56:19 +1100 [thread overview]
Message-ID: <1425282979.4636.10.camel@au1.ibm.com> (raw)
In-Reply-To: <20150302075036.GH21571@richard>
On Mon, 2015-03-02 at 15:50 +0800, Wei Yang wrote:
> >
> >Is there a hotplug remove path where we should also be calling
> >iommu_free_table()?
>
> When VF is not introduced, no one calls this on powernv platform.
>
> Each PCI bus is a PE and it has its own iommu table, even a device is
> hotpluged, the iommu table will not be released.
Actually, I believe Alexey patches to add support for dynamic DMA
windows for KVM guests using VFIO will also alloc/free iommu tables. In
fact his patches somewhat change quite a few things in that area, and
I'm currently reviewing them.
Wei, can you post a new series when you've finished sync'ing with
Bjorn ? At that point, I'll try to work with Alexey to evaluate the
impact of his changes on your patches.
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@au1.ibm.com>
To: Wei Yang <weiyang@linux.vnet.ibm.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
gwshan@linux.vnet.ibm.com
Subject: Re: [PATCH v12 14/21] powerpc/powernv: Allocate struct pnv_ioda_pe iommu_table dynamically
Date: Mon, 02 Mar 2015 18:56:19 +1100 [thread overview]
Message-ID: <1425282979.4636.10.camel@au1.ibm.com> (raw)
In-Reply-To: <20150302075036.GH21571@richard>
On Mon, 2015-03-02 at 15:50 +0800, Wei Yang wrote:
> >
> >Is there a hotplug remove path where we should also be calling
> >iommu_free_table()?
>
> When VF is not introduced, no one calls this on powernv platform.
>
> Each PCI bus is a PE and it has its own iommu table, even a device is
> hotpluged, the iommu table will not be released.
Actually, I believe Alexey patches to add support for dynamic DMA
windows for KVM guests using VFIO will also alloc/free iommu tables. In
fact his patches somewhat change quite a few things in that area, and
I'm currently reviewing them.
Wei, can you post a new series when you've finished sync'ing with
Bjorn ? At that point, I'll try to work with Alexey to evaluate the
impact of his changes on your patches.
Cheers,
Ben.
next prev parent reply other threads:[~2015-03-02 7:57 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 8:32 [PATCH v12 00/21] Enable SRIOV on Power8 Bjorn Helgaas
2015-02-24 8:33 ` [PATCH v12 01/21] PCI: Print more info in sriov_enable() error message Bjorn Helgaas
2015-02-24 8:33 ` [PATCH v12 02/21] PCI: Print PF SR-IOV resource that contains all VF(n) BAR space Bjorn Helgaas
2015-02-24 8:33 ` [PATCH v12 03/21] PCI: Keep individual VF BAR size in struct pci_sriov Bjorn Helgaas
2015-02-24 8:33 ` [PATCH v12 04/21] PCI: Index IOV resources in the conventional style Bjorn Helgaas
2015-02-24 8:33 ` [PATCH v12 05/21] PCI: Refresh First VF Offset and VF Stride when updating NumVFs Bjorn Helgaas
2015-02-24 8:33 ` [PATCH v12 06/21] PCI: Calculate maximum number of buses required for VFs Bjorn Helgaas
2015-02-24 8:33 ` [PATCH v12 07/21] PCI: Export pci_iov_virtfn_bus() and pci_iov_virtfn_devfn() Bjorn Helgaas
2015-02-24 8:33 ` [PATCH v12 08/21] PCI: Add pcibios_sriov_enable() and pcibios_sriov_disable() Bjorn Helgaas
2015-02-24 8:39 ` Bjorn Helgaas
2015-03-02 6:53 ` Wei Yang
2015-03-02 6:53 ` Wei Yang
2015-02-24 8:33 ` [PATCH v12 09/21] PCI: Add pcibios_iov_resource_alignment() interface Bjorn Helgaas
2015-02-24 8:34 ` [PATCH v12 10/21] PCI: Consider additional PF's IOV BAR alignment in sizing and assigning Bjorn Helgaas
2015-02-24 8:41 ` Bjorn Helgaas
2015-03-02 7:32 ` Wei Yang
2015-03-02 7:32 ` Wei Yang
2015-03-11 2:36 ` Bjorn Helgaas
2015-03-11 2:36 ` Bjorn Helgaas
2015-03-11 9:17 ` Wei Yang
2015-03-11 9:17 ` Wei Yang
2015-02-24 8:34 ` [PATCH v12 11/21] powerpc/pci: Don't unset PCI resources for VFs Bjorn Helgaas
2015-02-24 8:44 ` Bjorn Helgaas
2015-03-02 7:34 ` Wei Yang
2015-03-02 7:34 ` Wei Yang
2015-02-24 8:34 ` [PATCH v12 12/21] powerpc/pci: Refactor pci_dn Bjorn Helgaas
2015-02-24 8:34 ` [PATCH v12 13/21] powerpc/powernv: Use pci_dn, not device_node, in PCI config accessor Bjorn Helgaas
2015-02-24 8:34 ` [PATCH v12 14/21] powerpc/powernv: Allocate struct pnv_ioda_pe iommu_table dynamically Bjorn Helgaas
2015-02-24 8:46 ` Bjorn Helgaas
2015-03-02 7:50 ` Wei Yang
2015-03-02 7:50 ` Wei Yang
2015-03-02 7:56 ` Benjamin Herrenschmidt [this message]
2015-03-02 7:56 ` Benjamin Herrenschmidt
2015-03-02 8:02 ` Wei Yang
2015-03-02 8:02 ` Wei Yang
2015-03-11 2:47 ` Bjorn Helgaas
2015-03-11 2:47 ` Bjorn Helgaas
2015-03-11 6:13 ` Wei Yang
2015-03-11 6:13 ` Wei Yang
2015-02-24 8:34 ` [PATCH v12 15/21] powerpc/powernv: Reserve additional space for IOV BAR according to the number of total_pe Bjorn Helgaas
2015-02-24 8:52 ` Bjorn Helgaas
2015-03-02 7:41 ` Wei Yang
2015-03-02 7:41 ` Wei Yang
2015-03-11 2:51 ` Bjorn Helgaas
2015-03-11 2:51 ` Bjorn Helgaas
2015-03-11 6:22 ` Wei Yang
2015-03-11 6:22 ` Wei Yang
2015-03-11 13:40 ` Bjorn Helgaas
2015-03-11 13:40 ` Bjorn Helgaas
2015-02-24 8:34 ` [PATCH v12 16/21] powerpc/powernv: Implement pcibios_iov_resource_alignment() on powernv Bjorn Helgaas
2015-02-24 8:34 ` [PATCH v12 17/21] powerpc/powernv: Shift VF resource with an offset Bjorn Helgaas
2015-02-24 9:00 ` Bjorn Helgaas
2015-02-24 17:10 ` Bjorn Helgaas
2015-03-02 7:58 ` Wei Yang
2015-03-02 7:58 ` Wei Yang
2015-03-04 3:01 ` Wei Yang
2015-03-04 3:01 ` Wei Yang
2015-03-11 2:55 ` Bjorn Helgaas
2015-03-11 2:55 ` Bjorn Helgaas
2015-03-11 6:42 ` Wei Yang
2015-03-11 6:42 ` Wei Yang
2015-02-24 9:03 ` Bjorn Helgaas
2015-02-24 8:35 ` [PATCH v12 18/21] powerpc/powernv: Reserve additional space for IOV BAR, with m64_per_iov supported Bjorn Helgaas
2015-02-24 9:06 ` Bjorn Helgaas
2015-03-02 7:55 ` Wei Yang
2015-03-02 7:55 ` Wei Yang
2015-02-24 8:35 ` [PATCH v12 19/21] powerpc/powernv: Group VF PE when IOV BAR is big on PHB3 Bjorn Helgaas
2015-02-24 8:35 ` [PATCH v12 20/21] powerpc/pci: Remove unused struct pci_dn.pcidev field Bjorn Helgaas
2015-02-24 8:35 ` [PATCH v12 21/21] powerpc/pci: Add PCI resource alignment documentation Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425282979.4636.10.camel@au1.ibm.com \
--to=benh@au1.ibm.com \
--cc=bhelgaas@google.com \
--cc=gwshan@linux.vnet.ibm.com \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=weiyang@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.