From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: Xen-unstable "make clean" error on a freshly cloned tree Date: Mon, 2 Mar 2015 09:40:44 +0000 Message-ID: <1425289244.1886.6.camel@citrix.com> References: <1111974182.20150301233053@eikelenboom.it> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YSMqH-0008J6-Et for xen-devel@lists.xenproject.org; Mon, 02 Mar 2015 09:40:49 +0000 In-Reply-To: <1111974182.20150301233053@eikelenboom.it> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Sander Eikelenboom Cc: xen-devel , Wei Liu List-Id: xen-devel@lists.xenproject.org On Sun, 2015-03-01 at 23:30 +0100, Sander Eikelenboom wrote: > Hi Wei / Ian, > > I'm getting this error on a "make clean" on a freshly > cloned xen-unstable staging tree. It's probably because the make script > can't handle a make clean on a tree which hasn't cloned the mini-os tree > at least once as part of a build. Yes. I thought we had addressed that during review, but it seems we only caught one of the two places. Wei, I think this bit of stubdom/Makefile: ifeq ($(wildcard $(MINI_OS)/Config.mk),) $(error Please run `make mini-os-dir' in top-level directory) endif Needs something like this pattern from the end of tools/Rules.mk, combined with the wildcard stuff (or switching to a dependency on Config.mk): ifeq (,$(findstring clean,$(MAKECMDGOALS))) $(XEN_ROOT)/config/Tools.mk: $(error You have to run ./configure before building or installing the tools) endif I think that'll catch clean and distclean. Can you whip up a patch please. Ian.