From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH 2/2] xen: arm: Warn if timer interrupts are
 not level triggered
Date: Mon, 2 Mar 2015 11:13:00 +0000
Message-ID: <1425294780.1886.34.camel@citrix.com>
References: <1424359395.30924.89.camel@citrix.com>
	<1424359443-21584-2-git-send-email-ian.campbell@citrix.com>
	<54F23F23.4070506@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <54F23F23.4070506@linaro.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>
Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Sat, 2015-02-28 at 22:20 +0000, Julien Grall wrote:
> Hi Ian,
> 
> On 19/02/2015 15:24, Ian Campbell wrote:
> > +static void check_timer_irq_cfg(unsigned int irq, const char *which)
> > +{
> > +    struct irq_desc *desc = irq_to_desc(irq);
> > +
> > +    /*
> > +     * The interrupt contoller driver will update desc->arch.type with
> > +     * the actual type which ended up configured in the hardware.
> > +     */
> > +    if ( desc->arch.type & DT_IRQ_TYPE_LEVEL_LOW )
> > +        return;
> 
> I should have spotted it before ... The timer interrupts can be either 
> level low or high.
> 
> For instance Seattle is using level high interrupts. Therefore, the 
> error message will be odd on this platform.
> 
> I will send a patch Monday to fix it.

Thanks.