From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v4 6/8] xen/iommu: smmu: Add Xen specific
 code to be able to use the driver
Date: Mon, 2 Mar 2015 13:17:33 +0000
Message-ID: <1425302253.21151.13.camel@citrix.com>
References: <1424890381-4225-1-git-send-email-julien.grall@linaro.org>
	<1424890381-4225-7-git-send-email-julien.grall@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1YSQEE-0001W1-Gm
	for xen-devel@lists.xenproject.org; Mon, 02 Mar 2015 13:17:46 +0000
In-Reply-To: <1424890381-4225-7-git-send-email-julien.grall@linaro.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>
Cc: xen-devel@lists.xenproject.org, manish.jaggi@caviumnetworks.com, stefano.stabellini@citrix.com, tim@xen.org
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-02-25 at 18:52 +0000, Julien Grall wrote:
> The main goal is to modify as little the Linux code to be able to port
> easily new feature added in Linux repo for the driver.
> 
> To achieve that we:
>     - Add helpers to Linux function not implemented on Xen
>     - Add callbacks used by Xen to do our own stuff and call Linux ones
>     - Only modify when required the code which comes from Linux. If so a
>     comment has been added with /* Xen: ... */ explaining why it's
>     necessary.
> 
> The support for PCI has been commented because it's not yet supported by
> Xen ARM and therefore won't compile.
> 
> Signed-off-by: Julien Grall <julien.grall@linaro.org>

Looks good to me now, thanks. Couple of nits inline, but otherwise:
Acked-by: Ian Campbell <ian.campbell@citrix.com>

> + * This is because Linux has a field iommu_group in the struct device. On Xen,
> + * that would require to move so hackery (dummy iommu_group) in a more generic

Was "so" here supposed to be "some"?

> @@ -546,6 +819,9 @@ static int register_smmu_master(struct arm_smmu_device *smmu,
>  	master->of_node			= masterspec->np;
>  	master->cfg.num_streamids	= masterspec->args_count;
>  
> +	/* Xen: Let Xen knows that the device is protected by an SMMU */

s/knows/know/

Ian.