From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v4 6/8] xen/iommu: smmu: Add Xen specific code to be able to use the driver Date: Mon, 2 Mar 2015 13:54:38 +0000 Message-ID: <1425304478.21151.30.camel@citrix.com> References: <1424890381-4225-1-git-send-email-julien.grall@linaro.org> <1424890381-4225-7-git-send-email-julien.grall@linaro.org> <1425302253.21151.13.camel@citrix.com> <54F46986.1070505@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YSQnz-0007Sk-HD for xen-devel@lists.xenproject.org; Mon, 02 Mar 2015 13:54:43 +0000 In-Reply-To: <54F46986.1070505@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: xen-devel@lists.xenproject.org, manish.jaggi@caviumnetworks.com, stefano.stabellini@citrix.com, tim@xen.org List-Id: xen-devel@lists.xenproject.org On Mon, 2015-03-02 at 13:45 +0000, Julien Grall wrote: > Hi Ian, > > On 02/03/15 13:17, Ian Campbell wrote: > > On Wed, 2015-02-25 at 18:52 +0000, Julien Grall wrote: > >> The main goal is to modify as little the Linux code to be able to port > >> easily new feature added in Linux repo for the driver. > >> > >> To achieve that we: > >> - Add helpers to Linux function not implemented on Xen > >> - Add callbacks used by Xen to do our own stuff and call Linux ones > >> - Only modify when required the code which comes from Linux. If so a > >> comment has been added with /* Xen: ... */ explaining why it's > >> necessary. > >> > >> The support for PCI has been commented because it's not yet supported by > >> Xen ARM and therefore won't compile. > >> > >> Signed-off-by: Julien Grall > > > > Looks good to me now, thanks. Couple of nits inline, but otherwise: > > Acked-by: Ian Campbell > > Thanks for the ack. > > >> + * This is because Linux has a field iommu_group in the struct device. On Xen, > >> + * that would require to move so hackery (dummy iommu_group) in a more generic > > > > Was "so" here supposed to be "some"? > > Yes. > > >> @@ -546,6 +819,9 @@ static int register_smmu_master(struct arm_smmu_device *smmu, > >> master->of_node = masterspec->np; > >> master->cfg.num_streamids = masterspec->args_count; > >> > >> + /* Xen: Let Xen knows that the device is protected by an SMMU */ > > > > s/knows/know/ > > Yes. > > Given that the series has been acked up to this patch (#6), would it be > possible to apply the patches #1-#6)? Yes, for some reason I thought only up to #6 wasn't useful because it hadn't reinstated the driver yet, but I seem to have miscounted. I'll apply that subset shortly (and fixup the things above). > The patch #7 is not strictly necessary, by default Xen will flush the > cache for the PT. > > If it's fine for you, I will resend the patch #7 separately. Please do, thanks. Ian.