From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: xen-devel@lists.xensource.com, Ian.Jackson@eu.citrix.com,
dslutz@verizon.com,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH v6] libxl_set_memory_target: retain the same maxmem offset on top of the current target
Date: Mon, 2 Mar 2015 14:05:18 +0000 [thread overview]
Message-ID: <1425305118.21151.36.camel@citrix.com> (raw)
In-Reply-To: <20150302113637.GB11855@zion.uk.xensource.com>
On Mon, 2015-03-02 at 11:36 +0000, Wei Liu wrote:
> On Fri, Feb 27, 2015 at 12:45:47PM +0000, Stefano Stabellini wrote:
> > In libxl_set_memory_target when setting the new maxmem, retain the same
> > offset on top of the current target. In the future the offset will
> > include memory allocated by QEMU for rom files.
> >
>
> Sorry for not having mentioned this earlier.
>
> I think the behaviour of this API is changed now (for good reason).
>
> Ian and Ian, do want need a #define in libxl.h to mark such change?
I'm not sure, but I don't think that changes to the internal
calculations regarding overheads count as a libxl ABI change.
By analogy we don't break ABI/API if Xen happens to need an extra page
of memory to deal with a guest.
Other than Wei's comment about initialising the dominfo this looks good
to me.
next prev parent reply other threads:[~2015-03-02 14:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 12:45 [PATCH v6] libxl_set_memory_target: retain the same maxmem offset on top of the current target Stefano Stabellini
2015-03-02 11:36 ` Wei Liu
2015-03-02 14:05 ` Ian Campbell [this message]
2015-03-02 14:34 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425305118.21151.36.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=dslutz@verizon.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.