From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754436AbbCBOU4 (ORCPT ); Mon, 2 Mar 2015 09:20:56 -0500 Received: from smtprelay0164.hostedemail.com ([216.40.44.164]:54224 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754399AbbCBOUx (ORCPT ); Mon, 2 Mar 2015 09:20:53 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:968:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2692:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3873:3874:4321:5007:6119:6261:10004:10400:10848:11026:11232:11658:11914:12043:12517:12519:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: shake54_75e990be870c X-Filterd-Recvd-Size: 1694 Message-ID: <1425306048.31561.16.camel@perches.com> Subject: Re: [PATCH] Staging: fbtft: fix space errors From: Joe Perches To: Dan Carpenter Cc: Matteo Semenzato , gregkh@linuxfoundation.org, noralf@tronnes.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org Date: Mon, 02 Mar 2015 06:20:48 -0800 In-Reply-To: <20150302093704.GE5386@mwanda> References: <1425134695-10280-1-git-send-email-mattew8898@gmail.com> <1425135559.25697.2.camel@perches.com> <20150302093704.GE5386@mwanda> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.7-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-03-02 at 12:37 +0300, Dan Carpenter wrote: > On Sat, Feb 28, 2015 at 06:59:19AM -0800, Joe Perches wrote: > > If you're really going to change these, please > > remove the unnecessary \ line continuations > > indent the blocks properly and group the blocks > > more intelligibly. Maybe something like; > > > > static const int st7735r_init[] = { > > -1, 0x01, [] > > -2, 10, > > -3 > > }; > > What's the logic here? Why are we putting the negatives first? Those are delimiters. see fbtft-core.c:fbtft_init_display(). As far as I understand: -1, start of block -2, millisecond delay after block write -3, end of blocks Beyond that, I don't much care. I just prefer intelligible over apparently random.