From: Ian Campbell <ian.campbell@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH v5] tools/xenconsoled: Increase file descriptor limit
Date: Mon, 2 Mar 2015 14:22:27 +0000 [thread overview]
Message-ID: <1425306147.21151.50.camel@citrix.com> (raw)
In-Reply-To: <1425059586-30456-1-git-send-email-andrew.cooper3@citrix.com>
On Fri, 2015-02-27 at 17:53 +0000, Andrew Cooper wrote:
> XenServer's VM density testing uncovered a regression when moving from
> sysvinit to systemd where the file descriptor limit dropped from 4096 to
> 1024. (XenServer had previously inserted a ulimit statement into its
> initscripts.)
>
> One solution is to use LimitNOFILE=4096 in xenconsoled.service to match the
> lost ulimit, but that is only a stopgap solution.
>
> As Xenconsoled genuinely needs a large number of file descriptors if a large
> number of domains are running, attempt to increase the limit.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Ian Campbell <Ian.Campbell@citrix.com>
> CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
> CC: Wei Liu <wei.liu2@citrix.com>
I tried to apply but I'm afraid that for 32-bit userspace this gives me:
daemon/main.c: In function 'increase_fd_limit':
daemon/main.c:89:10: error: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'rlim_t' [-Werror=format]
daemon/main.c:89:10: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'rlim_t' [-Werror=format]
daemon/main.c:89:10: error: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'rlim_t' [-Werror=format]
daemon/main.c:89:10: error: format '%lu' expects argument of type 'long unsigned int', but argument 6 has type 'rlim_t' [-Werror=format]
I've no idea how one is formally supposed to print and rlim_r.
Ian.
next prev parent reply other threads:[~2015-03-02 14:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 17:53 [PATCH v5] tools/xenconsoled: Increase file descriptor limit Andrew Cooper
2015-02-27 17:57 ` Ian Jackson
2015-03-02 14:22 ` Ian Campbell [this message]
2015-03-02 14:23 ` Ian Campbell
2015-03-02 14:24 ` Andrew Cooper
2015-03-02 14:31 ` Ian Campbell
2015-03-02 15:04 ` [PATCH v6] " Andrew Cooper
2015-03-02 16:59 ` Ian Campbell
2015-03-16 13:36 ` Frediano Ziglio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425306147.21151.50.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.