From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH 2/2] tools: provide distclean target for OVMF
Date: Mon, 2 Mar 2015 14:35:31 +0000
Message-ID: <1425306931.21151.62.camel@citrix.com>
References: <1425293541-26183-1-git-send-email-wei.liu2@citrix.com>
	<1425293541-26183-3-git-send-email-wei.liu2@citrix.com>
	<1425306057.21151.49.camel@citrix.com>
	<20150302143130.GE11855@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20150302143130.GE11855@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: anthony.perard@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Mon, 2015-03-02 at 14:31 +0000, Wei Liu wrote:
> On Mon, Mar 02, 2015 at 02:20:57PM +0000, Ian Campbell wrote:
> > On Mon, 2015-03-02 at 10:52 +0000, Wei Liu wrote:
> > > OVMF's distclean target was missed in f9c9b1277 (tools: fix "make
> > > distclean").
> > 
> > tools/firmware/Makefile has:
> > subdir-distclean-ovmf: .phony
> >         rm -rf ovmf-dir ovmf-dir-remote
> > 
> > Shouldn't this be avoiding recursing into ovmf-dir in the first place?
> > 
> > Or is there some other reason to want this?
> > 
> 
> If you're in firmware directory and do "make distclean", make will
> recurse into ovmf to do "make distclean".

Really? Despite the rule I quoted above? How strange, I wonder why that
is.

I'd have expected "make distclean" to behave the same whether run in the
directory or recursed into frmo a higher level.

> 
> Wei.
> 
> > > 
> > > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > > Cc: Anthony Perard <anthony.perard@citrix.com>
> > > Cc: Ian Campbell <ian.campbell@citrix.com>
> > > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > > ---
> > >  tools/firmware/ovmf-makefile | 3 +++
> > >  1 file changed, 3 insertions(+)
> > > 
> > > diff --git a/tools/firmware/ovmf-makefile b/tools/firmware/ovmf-makefile
> > > index 2838744..c922d4d 100644
> > > --- a/tools/firmware/ovmf-makefile
> > > +++ b/tools/firmware/ovmf-makefile
> > > @@ -22,3 +22,6 @@ build:
> > >  .PHONY: clean
> > >  clean:
> > >  	rm -rf ovmf.bin Build/*
> > > +
> > > +.PHONY: distclean
> > > +distclean: clean
> >