From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] libxl: remove freemem_slack Date: Mon, 2 Mar 2015 14:49:37 +0000 Message-ID: <1425307777.21151.68.camel@citrix.com> References: <1424876845-29669-2-git-send-email-stefano.stabellini@eu.citrix.com> <2004339.Emeu92soFG@mlatimer1.dnsdhcp.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <2004339.Emeu92soFG@mlatimer1.dnsdhcp.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Mike Latimer Cc: ian.jackson@eu.citrix.com, Stefano Stabellini , wei.liu2@citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Wed, 2015-02-25 at 18:01 -0700, Mike Latimer wrote: > On Wednesday, February 25, 2015 03:07:25 PM Stefano Stabellini wrote: > > freemem_slack accounts for the amount of memory to be left free in the > > system because empirical experiments seem to demonstrate that is needed > > for "stability reasons". > > > > As we don't have any actual data on these stability issues, remove it. > > > > Signed-off-by: Stefano Stabellini > > I just finished tested this patch in conjunction with the LIBXL_MAXMEM_CONSTANT > removal patch. The freemem_slack zone is no longer reserved, and that aspect > of the ballooning issue appears fixed. > > There is still a problem with xl's freemem loop, but we can investigate that > further with slack out of the picture. > > From my side: > > Acked-by: Mike Latimer Me too. I think I'm right in saying that this patch isn't affected by any of the other on going discussion, so I've applied it. Please let me know if I was wrong!