From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 2/2] tools: provide distclean target for OVMF Date: Mon, 2 Mar 2015 14:54:25 +0000 Message-ID: <1425308065.21151.75.camel@citrix.com> References: <1425293541-26183-1-git-send-email-wei.liu2@citrix.com> <1425293541-26183-3-git-send-email-wei.liu2@citrix.com> <1425306057.21151.49.camel@citrix.com> <20150302143130.GE11855@zion.uk.xensource.com> <1425306931.21151.62.camel@citrix.com> <20150302144512.GG11855@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150302144512.GG11855@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: anthony.perard@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Mon, 2015-03-02 at 14:45 +0000, Wei Liu wrote: > On Mon, Mar 02, 2015 at 02:35:31PM +0000, Ian Campbell wrote: > > On Mon, 2015-03-02 at 14:31 +0000, Wei Liu wrote: > > > On Mon, Mar 02, 2015 at 02:20:57PM +0000, Ian Campbell wrote: > > > > On Mon, 2015-03-02 at 10:52 +0000, Wei Liu wrote: > > > > > OVMF's distclean target was missed in f9c9b1277 (tools: fix "make > > > > > distclean"). > > > > > > > > tools/firmware/Makefile has: > > > > subdir-distclean-ovmf: .phony > > > > rm -rf ovmf-dir ovmf-dir-remote > > > > > > > > Shouldn't this be avoiding recursing into ovmf-dir in the first place? > > > > > > > > Or is there some other reason to want this? > > > > > > > > > > If you're in firmware directory and do "make distclean", make will > > > recurse into ovmf to do "make distclean". > > > > Really? Despite the rule I quoted above? How strange, I wonder why that > > is. > > > > I'd have expected "make distclean" to behave the same whether run in the > > directory or recursed into frmo a higher level. > > > > The problem is that subdir-distclean-ovmf should have been > subdir-distclean-ovmf-dir. I think you prefer I fix it this way? You guessed right! > subidr-clean-ovmf should be -ovmf-dir following the same rule. I shall > fix them all in one go. Yes please. > > Wei. > > > > > > > Wei. > > > > > > > > > > > > > Signed-off-by: Wei Liu > > > > > Cc: Anthony Perard > > > > > Cc: Ian Campbell > > > > > Cc: Ian Jackson > > > > > --- > > > > > tools/firmware/ovmf-makefile | 3 +++ > > > > > 1 file changed, 3 insertions(+) > > > > > > > > > > diff --git a/tools/firmware/ovmf-makefile b/tools/firmware/ovmf-makefile > > > > > index 2838744..c922d4d 100644 > > > > > --- a/tools/firmware/ovmf-makefile > > > > > +++ b/tools/firmware/ovmf-makefile > > > > > @@ -22,3 +22,6 @@ build: > > > > > .PHONY: clean > > > > > clean: > > > > > rm -rf ovmf.bin Build/* > > > > > + > > > > > +.PHONY: distclean > > > > > +distclean: clean > > > > > >