From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v6 09/23] libxl: introduce
	libxl__vnuma_config_check
Date: Mon, 2 Mar 2015 15:34:58 +0000
Message-ID: <1425310498.21151.89.camel@citrix.com>
References: <1424966166-2388-1-git-send-email-wei.liu2@citrix.com>
	<1424966166-2388-10-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1424966166-2388-10-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: Dario Faggioli <dario.faggioli@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Elena Ufimtseva <ufimtseva@gmail.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Thu, 2015-02-26 at 15:55 +0000, Wei Liu wrote:
> This function is used to check whether vNUMA configuration (be it
> auto-generated or supplied by user) is valid.
> 
> Define a new error code ERROR_VNUMA_CONFIG_INVALID.
> 
> The checks performed can be found in the comment of the function.
> 
> This vNUMA function (and future ones) is placed in a new file called
> libxl_vnuma.c
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>

Although I'd like to see comment from Dario and/or Elena. (Ian's
concerns from last round look to me to have been addresses, Im sure
he'll speak up if not).

I have one question:
> + *  4. local distance cannot be larger than remote distance

What is the "local distance" in NUMA speak?