From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v5 08/24] libxl: introduce libxl__vnuma_config_check Date: Mon, 2 Mar 2015 16:05:26 +0000 Message-ID: <1425312326.23379.11.camel@citrix.com> References: <1423770294-9779-1-git-send-email-wei.liu2@citrix.com> <1423770294-9779-9-git-send-email-wei.liu2@citrix.com> <54DE1AF0.80304@citrix.com> <20150217125658.GD2159@zion.uk.xensource.com> <1425309188.21151.79.camel@citrix.com> <54F48107.2010307@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <54F48107.2010307@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper Cc: Wei Liu , ufimtseva@gmail.com, dario.faggioli@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, JBeulich@suse.com List-Id: xen-devel@lists.xenproject.org On Mon, 2015-03-02 at 15:25 +0000, Andrew Cooper wrote: > On 02/03/15 15:13, Ian Campbell wrote: > > On Tue, 2015-02-17 at 12:56 +0000, Wei Liu wrote: > > > >>>> + LOG(ERROR, "Invalid pnode %d specified", pnode); > >>> pnode is uint32_t, so should be %u > > Actually PRId32 is correct for a uint32_t, although I guess %u will work > > on all platforms we support. > > > > > > PRId32 and PRIu32 differ in string representation if the top bit of > pnode is set. > > pnode is unsigned, so should never be formatted with a signed identifier. Oops, I did indeed mean PRIu32. My main point was that the PRI_32 stuff should be used, not %u as you were suggesting. Ian.