Re: [PATCH v7 2/3] xen/arm: Make gic-v2 code handle hip04-d01 platform

[Ian Campbell <ian.campbell@citrix.com>]

On Fri, 2015-02-27 at 14:44 +0000, Frediano Ziglio wrote:
> The GIC in this platform is mainly compatible with the standard
> GICv2 beside:
> - ITARGET is extended to 16 bit to support 16 CPUs;
> - SGI mask is extended to support 16 CPUs;
> - maximum supported interrupt is 510;
> - GICH APR and LR register offsets.
> 
> Signed-off-by: Frediano Ziglio <frediano.ziglio@huawei.com>
> Signed-off-by: Zoltan Kiss <zoltan.kiss@huawei.com>
> ---
>  xen/arch/arm/Makefile       |   1 +
>  xen/arch/arm/domain_build.c |   2 +-
>  xen/arch/arm/gic-hip04.c    | 400 +++++++++++++++++++++++---------------------

Please add an entry to the MAINTAINERS file for this new driver.

>  3 files changed, 207 insertions(+), 196 deletions(-)
> 
> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
> index 41aba2e..72499e9 100644
> --- a/xen/arch/arm/Makefile
> +++ b/xen/arch/arm/Makefile
> @@ -12,6 +12,7 @@ obj-y += domctl.o
>  obj-y += sysctl.o
>  obj-y += domain_build.o
>  obj-y += gic.o gic-v2.o
> +obj-$(arm32) += gic-hip04.o
>  obj-$(CONFIG_ARM_64) += gic-v3.o

Please follow the example immediately below the line you added.

>  obj-y += io.o
>  obj-y += irq.o
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 9f1f59f..83951a3 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -1069,7 +1069,7 @@ static int handle_node(struct domain *d, struct kernel_info *kinfo,
>  
>      /* Replace these nodes with our own. Note that the original may be
>       * used_by DOMID_XEN so this check comes first. */
> -    if ( dt_match_node(gic_matches, node) )
> +    if ( node == dt_interrupt_controller || dt_match_node(gic_matches, node) )
>          return make_gic_node(d, kinfo->fdt, node);

This generic change should be its own patch, with a suitable
justification etc.

Ian.