All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Zanussi <tom.zanussi@linux.intel.com>
To: Alexei Starovoitov <ast@plumgrid.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Andi Kleen <andi@firstfloor.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 07/15] mm: Add ___GFP_NOTRACE
Date: Mon, 02 Mar 2015 16:04:05 -0600	[thread overview]
Message-ID: <1425333845.20819.60.camel@picadillo> (raw)
In-Reply-To: <CAMEtUuwvJZZ2UpMGm+=BJ88W87EOb-Rof4Ai3ya+Mto5_K8Thg@mail.gmail.com>

On Mon, 2015-03-02 at 11:29 -0800, Alexei Starovoitov wrote:
> On Mon, Mar 2, 2015 at 10:54 AM, Tom Zanussi
> <tom.zanussi@linux.intel.com> wrote:
> >> >
> >> > The idea would be that instead of getting your individually kmalloc'ed
> >> > elements on-demand from kmalloc while in the handler, you'd get them
> >> > from a pool you've pre-allocated when you set up the table.  This could
> >> > be from a list of individual entries you've already kmalloc'ed ahead of
> >> > time, or from an array of n * sizeof(entry).
> >>
> >> would work, but kinda ugly, since we will pre-allocate a lot
> >> and may not be using it at all.
> >>
> >
> > That's true but you have a user-defined map limit anyway, which you can
> > adjust to minimize wastage.  And allocating ahead of time also means you
> > perturb the system less while actually tracing.
> 
> nope. it's the other way around.
> using kmalloc is faster and less overhead on the whole system
> then grabbing cache-cold objects from special pool.

Until you start causing GFP_ATOMIC failures for what you're tracing
because your map has grabbed them all...

Tom

> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



  reply	other threads:[~2015-03-02 22:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-02 19:29 [PATCH 07/15] mm: Add ___GFP_NOTRACE Alexei Starovoitov
2015-03-02 22:04 ` Tom Zanussi [this message]
2015-03-02 23:21   ` Alexei Starovoitov
  -- strict thread matches above, loose matches on Subject: below --
2015-03-02 19:52 Alexei Starovoitov
2015-03-02 19:24 Alexei Starovoitov
2015-03-02 19:33 ` Steven Rostedt
2015-03-02 18:40 Alexei Starovoitov
2015-03-02 18:54 ` Tom Zanussi
2015-03-02 16:00 [PATCH v2 00/15] tracing: 'hist' triggers Tom Zanussi
2015-03-02 16:01 ` [PATCH 07/15] mm: Add ___GFP_NOTRACE Tom Zanussi
2015-03-02 16:37   ` Steven Rostedt
2015-03-02 16:46     ` Tom Zanussi
2015-03-02 17:58       ` Alexei Starovoitov
2015-03-02 18:03         ` Tom Zanussi
2015-03-02 18:12           ` Alexei Starovoitov
2015-03-02 18:25             ` Tom Zanussi
2015-03-02 18:43             ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425333845.20819.60.camel@picadillo \
    --to=tom.zanussi@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=ast@plumgrid.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=namhyung@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.