From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v6 09/23] libxl: introduce libxl__vnuma_config_check Date: Tue, 3 Mar 2015 03:52:29 +0000 Message-ID: <1425354747.10194.264.camel@citrix.com> References: <1424966166-2388-1-git-send-email-wei.liu2@citrix.com> <1424966166-2388-10-git-send-email-wei.liu2@citrix.com> <1425310498.21151.89.camel@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6625269506921154896==" Return-path: In-Reply-To: <1425310498.21151.89.camel@citrix.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Ian Jackson , Wei Liu , "ufimtseva@gmail.com" , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org --===============6625269506921154896== Content-Language: en-US Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-hByYFEddEZpMdOSSivyP" --=-hByYFEddEZpMdOSSivyP Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2015-03-02 at 15:34 +0000, Ian Campbell wrote: > On Thu, 2015-02-26 at 15:55 +0000, Wei Liu wrote: > > This function is used to check whether vNUMA configuration (be it > > auto-generated or supplied by user) is valid. > >=20 > > Define a new error code ERROR_VNUMA_CONFIG_INVALID. > >=20 > > The checks performed can be found in the comment of the function. > >=20 > > This vNUMA function (and future ones) is placed in a new file called > > libxl_vnuma.c > >=20 > > Signed-off-by: Wei Liu >=20 > Acked-by: Ian Campbell >=20 > Although I'd like to see comment from Dario and/or Elena. (Ian's > concerns from last round look to me to have been addresses, Im sure > he'll speak up if not). >=20 Yes, sorry for the delay. The (minor) concerns I had on v5 have been addressed, so: Reviewed-by: Dario Faggioli Dario --=-hByYFEddEZpMdOSSivyP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlT1L/sACgkQk4XaBE3IOsRYpwCePBG5uY1uxEzGxjOYOXm8URpM REkAn2HI9wkzO2gaqp7RMVCuqcGOYGn7 =103f -----END PGP SIGNATURE----- --=-hByYFEddEZpMdOSSivyP-- --===============6625269506921154896== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============6625269506921154896==--