From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH v2 1/3] xen/arm: Add ThunderX platform
	support
Date: Tue, 3 Mar 2015 09:03:04 +0000
Message-ID: <1425373384.12103.47.camel@citrix.com>
References: <1424261984-28324-1-git-send-email-vijay.kilari@gmail.com>
	<1424261984-28324-2-git-send-email-vijay.kilari@gmail.com>
	<54E487AB.6060703@linaro.org> <1424713864.27930.253.camel@citrix.com>
	<CALicx6utwMm2uMWbgN_T_Sn1a5CvFd9ZJ-5wb1jL2yF-sh62Pw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CALicx6utwMm2uMWbgN_T_Sn1a5CvFd9ZJ-5wb1jL2yF-sh62Pw@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Vijay Kilari <vijay.kilari@gmail.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Prasun Kapoor <Prasun.Kapoor@caviumnetworks.com>, Vijaya Kumar K <vijaya.kumar@caviumnetworks.com>, Julien Grall <julien.grall@linaro.org>, Tim Deegan <tim@xen.org>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Stefano Stabellini <stefano.stabellini@citrix.com>, manish.jaggi@caviumnetworks.com
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-03-03 at 10:39 +0530, Vijay Kilari wrote:
> On Mon, Feb 23, 2015 at 11:21 PM, Ian Campbell <ian.campbell@citrix.com> wrote:
> > On Wed, 2015-02-18 at 12:38 +0000, Julien Grall wrote:
> >> > +    uint64_t addr, size;
> >
> > Please use paddr_t and PRIpaddr etc.
> >
> >> > +    res = map_mmio_regions(d,
> >> > +                           paddr_to_pfn(addr & PAGE_MASK),
> >> > +                           DIV_ROUND_UP(size, PAGE_SIZE),
> >> > +                           paddr_to_pfn(addr & PAGE_MASK));
> >>
> >> OOI, why this region is not described in the DT? Is it a PCI device?
> >
> 
>  It is not PCI device. it is Global SerDes configuration region. It is not
> mentioned in DT.

Why not? Should it be?

> 
> > I'm curious too.
> >
> >> > +    if ( res )
> >> > +    {
> >> > +         printk(XENLOG_ERR "Unable to map to dom%d region"
> >>
> >> It would be more clear to specify the name of the region i.e "GSER region"
> >
> > Agreed.
> 
> OK. will be fixed
> 
> Regards,
> Vijay