From: Ian Campbell <ian.campbell@citrix.com>
To: Julien Grall <julien.grall@linaro.org>
Cc: Vijay Kilari <vijay.kilari@gmail.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Prasun Kapoor <Prasun.Kapoor@caviumnetworks.com>,
Vijaya Kumar K <vijaya.kumar@caviumnetworks.com>,
Tim Deegan <tim@xen.org>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
Stefano Stabellini <stefano.stabellini@citrix.com>,
manish.jaggi@caviumnetworks.com
Subject: Re: [PATCH v1] xen/arm: Do not allocate pte entries for MAP_SMALL_PAGES
Date: Tue, 3 Mar 2015 11:57:01 +0000 [thread overview]
Message-ID: <1425383821.24959.128.camel@citrix.com> (raw)
In-Reply-To: <54F5A03D.8010302@linaro.org>
On Tue, 2015-03-03 at 11:51 +0000, Julien Grall wrote:
>
> On 03/03/2015 11:47, Ian Campbell wrote:
> >> I'm not sure to follow here. Do you think MAP_SMALL_PAGES should be
> >> defined as WRITE_ALLOC?
> >
> > Sorry I just meant that:
> > +#define PAGE_HYPERVISOR_WC ((DEV_WC) | PTE_PRESENT )
> > should be just:
> > +#define PAGE_HYPERVISOR_WC (DEV_WC | PTE_PRESENT )
> > etc, no need for the inner-()s.
> >
> > MAP_SMALL_PAGES was correct as
> > +#define MAP_SMALL_PAGES (WRITEALLOC)
>
> I wanted to check the definition of MAP_SMALL_PAGES you were agreed.
>
> I think using WRITEALLOC here is confusing. There is no resulting PTE
> and therefore WRITEALLOC will never be set.
>
> I think it would be better to have a separate helper (as you suggested
> on a previous mail).
Ah yes, I'd forgotten I'd thought of that. A separate helper to
provision an empty PT range would indeed be the best thing here.
>
> Regards,
>
prev parent reply other threads:[~2015-03-03 11:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 12:56 [PATCH v1] xen/arm: Do not allocate pte entries for MAP_SMALL_PAGES vijay.kilari
2015-02-18 13:03 ` Julien Grall
2015-02-24 9:31 ` Ian Campbell
2015-02-24 9:38 ` Julien Grall
2015-02-24 10:17 ` Jan Beulich
2015-02-24 10:26 ` Ian Campbell
2015-02-24 12:59 ` Julien Grall
2015-02-24 13:13 ` Ian Campbell
2015-02-24 13:47 ` Julien Grall
2015-02-24 13:54 ` Jan Beulich
2015-03-03 7:58 ` Vijay Kilari
2015-03-03 10:27 ` Ian Campbell
2015-03-03 11:17 ` Julien Grall
2015-03-03 11:47 ` Ian Campbell
2015-03-03 11:51 ` Julien Grall
2015-03-03 11:57 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425383821.24959.128.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Prasun.Kapoor@caviumnetworks.com \
--cc=julien.grall@linaro.org \
--cc=manish.jaggi@caviumnetworks.com \
--cc=stefano.stabellini@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=vijay.kilari@gmail.com \
--cc=vijaya.kumar@caviumnetworks.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.