From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Keir Fraser <keir@xen.org>, Tim Deegan <tim@xen.org>,
Dario Faggioli <dario.faggioli@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] vNUMA: validate XEN_DOMCTL_setvnumainfo input
Date: Tue, 3 Mar 2015 14:53:10 +0000 [thread overview]
Message-ID: <1425394390.25940.23.camel@citrix.com> (raw)
In-Reply-To: <20150303144630.GY11855@zion.uk.xensource.com>
On Tue, 2015-03-03 at 14:46 +0000, Wei Liu wrote:
> On Tue, Mar 03, 2015 at 02:38:19PM +0000, Jan Beulich wrote:
> > As we get ready to use the information set for a domain here we should
> > make sure it is actually valid: Both vNode and pNode numbers should be
> > in range. Do a little bit of other cleanup so the code ends up looking
> > reasonably consistent in style.
> >
> > Along with this goes that we don't need an array of unsigned int to
> > store the pNode number - a nodeid_t one (a quarter the size) suffices.
> >
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
> >
>
> FWIW
>
> Reviewed-by: Wei Liu <wei.liu2@citrix.com>
Acked-by: Ian Campbell <ian.campbell@cigtrix.com>
next prev parent reply other threads:[~2015-03-03 14:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 14:38 [PATCH] vNUMA: validate XEN_DOMCTL_setvnumainfo input Jan Beulich
2015-03-03 14:46 ` Wei Liu
2015-03-03 14:53 ` Ian Campbell [this message]
2015-03-03 20:17 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425394390.25940.23.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=dario.faggioli@citrix.com \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.