From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] vNUMA: validate XEN_DOMCTL_setvnumainfo input Date: Tue, 3 Mar 2015 14:53:10 +0000 Message-ID: <1425394390.25940.23.camel@citrix.com> References: <54F5D56B0200007800065BB9@mail.emea.novell.com> <20150303144630.GY11855@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YSoCq-0001aM-Dp for xen-devel@lists.xenproject.org; Tue, 03 Mar 2015 14:53:56 +0000 In-Reply-To: <20150303144630.GY11855@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: Keir Fraser , Tim Deegan , Dario Faggioli , Ian Jackson , Jan Beulich , xen-devel List-Id: xen-devel@lists.xenproject.org On Tue, 2015-03-03 at 14:46 +0000, Wei Liu wrote: > On Tue, Mar 03, 2015 at 02:38:19PM +0000, Jan Beulich wrote: > > As we get ready to use the information set for a domain here we should > > make sure it is actually valid: Both vNode and pNode numbers should be > > in range. Do a little bit of other cleanup so the code ends up looking > > reasonably consistent in style. > > > > Along with this goes that we don't need an array of unsigned int to > > store the pNode number - a nodeid_t one (a quarter the size) suffices. > > > > Signed-off-by: Jan Beulich > > > > FWIW > > Reviewed-by: Wei Liu Acked-by: Ian Campbell