From: Mark Salter <msalter@redhat.com>
To: Chen Gang <762976180@qq.com>
Cc: a-jacquiot@ti.com, robh@kernel.org,
"linux-c6x-dev@linux-c6x.org" <linux-c6x-dev@linux-c6x.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] c6x: kernel: setup: Include "linux/console.h" if both VT and DUMMY_CONSOLE enabled
Date: Tue, 03 Mar 2015 11:54:17 -0500 [thread overview]
Message-ID: <1425401657.3240.63.camel@deneb.redhat.com> (raw)
In-Reply-To: <54F2C6D7.4020006@qq.com>
On Sun, 2015-03-01 at 15:59 +0800, Chen Gang wrote:
> Or c6x will cause building break for allmodconfig, the related error:
>
> CC arch/c6x/kernel/setup.o
> arch/c6x/kernel/setup.c: In function 'setup_arch':
> arch/c6x/kernel/setup.c:433:2: error: 'conswitchp' undeclared (first use in this function)
> conswitchp = &dummy_con;
> ^
> arch/c6x/kernel/setup.c:433:2: note: each undeclared identifier is reported only once for each function it appears in
> arch/c6x/kernel/setup.c:433:16: error: 'dummy_con' undeclared (first use in this function)
> conswitchp = &dummy_con;
> ^
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
> arch/c6x/kernel/setup.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/c6x/kernel/setup.c b/arch/c6x/kernel/setup.c
> index 7571288..a5f6e0e 100644
> --- a/arch/c6x/kernel/setup.c
> +++ b/arch/c6x/kernel/setup.c
> @@ -26,7 +26,9 @@
> #include <linux/cpu.h>
> #include <linux/fs.h>
> #include <linux/of.h>
> -
> +#if defined(CONFIG_VT) && defined(CONFIG_DUMMY_CONSOLE)
> +#include <linux/console.h>
> +#endif
No need for the #ifdefs around the include.
I removed them and pulled this into the c6x tree.
Thanks!
>
> #include <asm/sections.h>
> #include <asm/div64.h>
prev parent reply other threads:[~2015-03-03 16:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <54F2C6D7.4020006@qq.com>
2015-03-01 8:19 ` Fwd: [PATCH] c6x: kernel: setup: Include "linux/console.h" if both VT and DUMMY_CONSOLE enabled Chen Gang S
2015-03-03 16:54 ` Mark Salter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425401657.3240.63.camel@deneb.redhat.com \
--to=msalter@redhat.com \
--cc=762976180@qq.com \
--cc=a-jacquiot@ti.com \
--cc=linux-c6x-dev@linux-c6x.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.