From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756493AbbCCUEh (ORCPT ); Tue, 3 Mar 2015 15:04:37 -0500 Received: from smtprelay0163.hostedemail.com ([216.40.44.163]:35942 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757213AbbCCUEc (ORCPT ); Tue, 3 Mar 2015 15:04:32 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:800:960:967:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2525:2553:2560:2563:2682:2685:2828:2859:2895:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3871:3872:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:5007:6261:7576:7903:9025:10004:10400:10471:10481:10848:10967:11232:11658:11914:12043:12114:12517:12519:12740:13069:13255:13311:13357:14096:14097:19900:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: eye36_a42100629d52 X-Filterd-Recvd-Size: 1984 Message-ID: <1425413068.17273.58.camel@perches.com> Subject: Re: [PATCH net-next 01/14] etherdevice: Add eth__addr CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS code From: Joe Perches To: David Miller Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 03 Mar 2015 12:04:28 -0800 In-Reply-To: <20150303.145815.1129211297511474723.davem@davemloft.net> References: <1425409671.17273.42.camel@perches.com> <20150303.142758.822602589629075339.davem@davemloft.net> <1425411669.17273.52.camel@perches.com> <20150303.145815.1129211297511474723.davem@davemloft.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-03-03 at 14:58 -0500, David Miller wrote: > From: Joe Perches > Date: Tue, 03 Mar 2015 11:41:09 -0800 > > > Until such time as the linux crosstools compilers are updated, > > (they seem stuck on 4.6.3 from 3 years ago) > > https://www.kernel.org/pub/tools/crosstool/ > > I think the series is a trivial, small improvement. > > You are even admitting that even for your specific case you are > using 3+ year old compiler technology. That's what I said. How is it an "admission"? Those are the kernel.org "recommended" cross-compilers. > These are slow paths, so correctness is the most important aspect. > > Converting these locations to consistently use eth_*() is fine, > but then "optimizing" a 6 by memset for configuration paths when > the compiler should be more than capable of doing this just fine > is not convincing at all to me. Swell, then perhaps you could simply skip 1/14.