From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757078AbbCDNlS (ORCPT ); Wed, 4 Mar 2015 08:41:18 -0500 Received: from smtp.citrix.com ([66.165.176.89]:31207 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756231AbbCDNlR (ORCPT ); Wed, 4 Mar 2015 08:41:17 -0500 X-IronPort-AV: E=Sophos;i="5.09,687,1418083200"; d="scan'208";a="239791957" Message-ID: <1425476473.25940.158.camel@citrix.com> Subject: Re: [Xen-devel] [PATCH 3/4] usb: Introduce Xen pvUSB backend From: Ian Campbell To: Juergen Gross CC: David Vrabel , , , , , , , Date: Wed, 4 Mar 2015 13:41:13 +0000 In-Reply-To: <54F7091C.1050001@suse.com> References: <1424957717-392-1-git-send-email-jgross@suse.com> <1424957717-392-4-git-send-email-jgross@suse.com> <54F44BD5.1030008@citrix.com> <54F7091C.1050001@suse.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-03-04 at 14:31 +0100, Juergen Gross wrote: > >> - move module to appropriate location in kernel tree > > > > drivers/xen/ is the correct location for this driver. > > Hmm, so you regard placement of xen-netback under drivers/net and > xen-blkback under drivers/block as wrong? I've just followed these > examples. At least in the case of netback it really is just a normal Ethernet driver as far as the kernel is concerned. The fact it happens to talk to a virtual device doesn't matter. I don't know about other device types. Ian. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [Xen-devel] [PATCH 3/4] usb: Introduce Xen pvUSB backend Date: Wed, 4 Mar 2015 13:41:13 +0000 Message-ID: <1425476473.25940.158.camel@citrix.com> References: <1424957717-392-1-git-send-email-jgross@suse.com> <1424957717-392-4-git-send-email-jgross@suse.com> <54F44BD5.1030008@citrix.com> <54F7091C.1050001@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <54F7091C.1050001@suse.com> Sender: linux-kernel-owner@vger.kernel.org To: Juergen Gross Cc: David Vrabel , linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com, konrad.wilk@oracle.com, boris.ostrovsky@oracle.com, linux-usb@vger.kernel.org, gregkh@linuxfoundation.org, cyliu@suse.com List-Id: xen-devel@lists.xenproject.org On Wed, 2015-03-04 at 14:31 +0100, Juergen Gross wrote: > >> - move module to appropriate location in kernel tree > > > > drivers/xen/ is the correct location for this driver. > > Hmm, so you regard placement of xen-netback under drivers/net and > xen-blkback under drivers/block as wrong? I've just followed these > examples. At least in the case of netback it really is just a normal Ethernet driver as far as the kernel is concerned. The fact it happens to talk to a virtual device doesn't matter. I don't know about other device types. Ian.