From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: Re: [PATCH] vgaarb: Stub vga_set_legacy_decoding() Date: Wed, 04 Mar 2015 16:51:49 -0700 Message-ID: <1425513109.5200.321.camel@redhat.com> References: <20150224161239.7482.76673.stgit@gimli.home> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by gabe.freedesktop.org (Postfix) with ESMTP id 7FEE36E6FA for ; Wed, 4 Mar 2015 15:51:54 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dave Airlie Cc: LKML , dri-devel List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCAyMDE1LTAzLTA1IGF0IDA5OjQzICsxMDAwLCBEYXZlIEFpcmxpZSB3cm90ZToKPiBP biAyNSBGZWJydWFyeSAyMDE1IGF0IDAyOjE2LCBBbGV4IFdpbGxpYW1zb24KPiA8YWxleC53aWxs aWFtc29uQHJlZGhhdC5jb20+IHdyb3RlOgo+ID4gdmdhX3NldF9sZWdhY3lfZGVjb2RpbmcoKSBp cyBkZWZpbmVkIGluIGRyaXZlcnMvZ3B1L3ZnYS92Z2FhcmIuYywKPiA+IHdoaWNoIGlzIG9ubHkg Y29tcGlsZWQgd2l0aCBDT05GSUdfVkdBX0FSQi4gIEEgY2FsbGVyIHdvdWxkCj4gPiB0aGVyZWZv cmUgZ2V0IGFuIHVuZGVmaW5lZCBzeW1ib2wgaWYgdGhlIFZHQSBhcmJpdGVyIGlzIG5vdAo+ID4g ZW5hYmxlZC4KPiAKPiBBY2tlZC1ieTogRGF2ZSBBaXJsaWUgPGFpcmxpZWRAcmVkaGF0LmNvbT4K ClRoYW5rcyBEYXZlISAgSSdsbCByb3V0ZSB0aGlzIHRocm91Z2ggbXkgdHJlZSB3aXRoIHRoZSBj b21taXQgdGhhdCB1c2VzCml0LgoKPiA+IFNpZ25lZC1vZmYtYnk6IEFsZXggV2lsbGlhbXNvbiA8 YWxleC53aWxsaWFtc29uQHJlZGhhdC5jb20+Cj4gPiAtLS0KPiA+Cj4gPiBJJ2QgbGlrZSB0byB1 c2UgdGhpcyBmdW5jdGlvbiBmcm9tIHZmaW8tcGNpIHRvIG9wdC1vdXQgVkdBIGRldmljZXMKPiA+ IGZyb20gYXJiaXRyYXRpb24gaWYgdmZpby1wY2kgVkdBIHN1cHBvcnQgaXMgZGlzYWJsZWQuICBU aGlzIGhlbHBzIHRvCj4gPiBrZWVwIERSSTIgZW5hYmxlZCBvbiB0aGUgaG9zdCBpZiBhZGRpdGlv bmFsIEdQVXMgYXJlIGluc3RhbGxlZCBmb3IKPiA+IFZNcyBhbmQgdXNlZCB3aXRob3V0IFZHQSBz dXBwb3J0LiAgSSBjYW4gcHVsbCB0aGlzIGNoYW5nZSBpbiB0aHJvdWdoCj4gPiBteSB0cmVlIGlm IHNvbWVvbmUgd2FudHMgdG8gcHJvdmlkZSBqdXN0IGFuIGFjay4gIFRoYW5rcyEKPiA+Cj4gPiAg aW5jbHVkZS9saW51eC92Z2FhcmIuaCB8ICAgIDUgKysrKysKPiA+ICAxIGZpbGUgY2hhbmdlZCwg NSBpbnNlcnRpb25zKCspCj4gPgo+ID4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvdmdhYXJi LmggYi9pbmNsdWRlL2xpbnV4L3ZnYWFyYi5oCj4gPiBpbmRleCBjMzdiZDRkLi44YzNiNDEyIDEw MDY0NAo+ID4gLS0tIGEvaW5jbHVkZS9saW51eC92Z2FhcmIuaAo+ID4gKysrIGIvaW5jbHVkZS9s aW51eC92Z2FhcmIuaAo+ID4gQEAgLTY1LDggKzY1LDEzIEBAIHN0cnVjdCBwY2lfZGV2Owo+ID4g ICAqICAgICBvdXQgb2YgdGhlIGFyYml0cmF0aW9uIHByb2Nlc3MgKGFuZCBjYW4gYmUgc2FmZSB0 byB0YWtlCj4gPiAgICogICAgIGludGVycnVwdHMgYXQgYW55IHRpbWUuCj4gPiAgICovCj4gPiAr I2lmIGRlZmluZWQoQ09ORklHX1ZHQV9BUkIpCj4gPiAgZXh0ZXJuIHZvaWQgdmdhX3NldF9sZWdh Y3lfZGVjb2Rpbmcoc3RydWN0IHBjaV9kZXYgKnBkZXYsCj4gPiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgZGVjb2Rlcyk7Cj4gPiArI2Vsc2UKPiA+ICtz dGF0aWMgaW5saW5lIHZvaWQgdmdhX3NldF9sZWdhY3lfZGVjb2Rpbmcoc3RydWN0IHBjaV9kZXYg KnBkZXYsCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5z aWduZWQgaW50IGRlY29kZXMpIHsgfTsKPiA+ICsjZW5kaWYKPiA+Cj4gPiAgLyoqCj4gPiAgICog ICAgIHZnYV9nZXQgICAgICAgICAtIGFjcXVpcmUgJiBsb2NrcyBWR0EgcmVzb3VyY2VzCj4gPgo+ ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+IGRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKPiA+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK PiA+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWwKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753021AbbCDXv4 (ORCPT ); Wed, 4 Mar 2015 18:51:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48799 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751455AbbCDXvz (ORCPT ); Wed, 4 Mar 2015 18:51:55 -0500 Message-ID: <1425513109.5200.321.camel@redhat.com> Subject: Re: [PATCH] vgaarb: Stub vga_set_legacy_decoding() From: Alex Williamson To: Dave Airlie Cc: Dave Airlie , dri-devel , LKML Date: Wed, 04 Mar 2015 16:51:49 -0700 In-Reply-To: References: <20150224161239.7482.76673.stgit@gimli.home> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-03-05 at 09:43 +1000, Dave Airlie wrote: > On 25 February 2015 at 02:16, Alex Williamson > wrote: > > vga_set_legacy_decoding() is defined in drivers/gpu/vga/vgaarb.c, > > which is only compiled with CONFIG_VGA_ARB. A caller would > > therefore get an undefined symbol if the VGA arbiter is not > > enabled. > > Acked-by: Dave Airlie Thanks Dave! I'll route this through my tree with the commit that uses it. > > Signed-off-by: Alex Williamson > > --- > > > > I'd like to use this function from vfio-pci to opt-out VGA devices > > from arbitration if vfio-pci VGA support is disabled. This helps to > > keep DRI2 enabled on the host if additional GPUs are installed for > > VMs and used without VGA support. I can pull this change in through > > my tree if someone wants to provide just an ack. Thanks! > > > > include/linux/vgaarb.h | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/include/linux/vgaarb.h b/include/linux/vgaarb.h > > index c37bd4d..8c3b412 100644 > > --- a/include/linux/vgaarb.h > > +++ b/include/linux/vgaarb.h > > @@ -65,8 +65,13 @@ struct pci_dev; > > * out of the arbitration process (and can be safe to take > > * interrupts at any time. > > */ > > +#if defined(CONFIG_VGA_ARB) > > extern void vga_set_legacy_decoding(struct pci_dev *pdev, > > unsigned int decodes); > > +#else > > +static inline void vga_set_legacy_decoding(struct pci_dev *pdev, > > + unsigned int decodes) { }; > > +#endif > > > > /** > > * vga_get - acquire & locks VGA resources > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/dri-devel