All of lore.kernel.org
 help / color / mirror / Atom feed
From: Axel Lin <axel.lin@ingics.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Gabriel FERNANDEZ <gabriel.fernandez@st.com>,
	"kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Alexandre Torgue <alexandre.torgue@st.com>
Subject: [PATCH 1/2] phy: miphy28lp: Convert to devm_kcalloc and fix wrong sizof
Date: Thu, 05 Mar 2015 09:43:09 +0800	[thread overview]
Message-ID: <1425519789.1637.4.camel@phoenix> (raw)

Prefer devm_kcalloc over devm_kzalloc with multiply.
In additional, use sizeof(phy) is incorrect, fix it.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
This patch is on top of below patch:
[PATCH 1/2] phy: miphy28lp: Avoid calling of_get_child_count() multiple times

 drivers/phy/phy-miphy28lp.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/phy/phy-miphy28lp.c b/drivers/phy/phy-miphy28lp.c
index 4fe1755..9334352 100644
--- a/drivers/phy/phy-miphy28lp.c
+++ b/drivers/phy/phy-miphy28lp.c
@@ -1209,9 +1209,8 @@ static int miphy28lp_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	miphy_dev->nphys = of_get_child_count(np);
-	miphy_dev->phys = devm_kzalloc(&pdev->dev,
-				       sizeof(phy) * miphy_dev->nphys,
-				       GFP_KERNEL);
+	miphy_dev->phys = devm_kcalloc(&pdev->dev, miphy_dev->nphys,
+				       sizeof(*miphy_dev->phys), GFP_KERNEL);
 	if (!miphy_dev->phys)
 		return -ENOMEM;
 
-- 
1.9.1




             reply	other threads:[~2015-03-05  1:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-05  1:43 Axel Lin [this message]
2015-03-05  1:44 ` [PATCH 2/2] phy: miphy28lp: Use PTR_ERR_OR_ZERO Axel Lin
2015-03-05  9:00   ` Gabriel Fernandez
2015-03-05  9:00 ` [PATCH 1/2] phy: miphy28lp: Convert to devm_kcalloc and fix wrong sizof Gabriel Fernandez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425519789.1637.4.camel@phoenix \
    --to=axel.lin@ingics.com \
    --cc=alexandre.torgue@st.com \
    --cc=gabriel.fernandez@st.com \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.