All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cristina Opriceana <cristina.opriceana@gmail.com>
To: Jes Sorensen <jes.sorensen@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] Staging: rtl8192u: Bool tests don't need comparisons
Date: Thu, 05 Mar 2015 11:25:57 +0200	[thread overview]
Message-ID: <1425547557.5320.8.camel@Inspiron> (raw)
In-Reply-To: <54F7B301.8020203@gmail.com>

On Mi, 2015-03-04 at 20:36 -0500, Jes Sorensen wrote:
> This patch is technically correct, the only issue is with some cases
> where you touch a line, you should try to fix up other aesthetic issues
> on the same line while you are at it.

Thanks for the observation. I will fix these.

Also, what should I do with files that have serious indentation
problems? For example, I was trying to fix something on
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c but this file
has ifs is ifs in switch (lines 2012+), therefore multiple tab levels
and surpasses the limit of 80 characters.

Cristina



      reply	other threads:[~2015-03-05  9:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-04 23:07 [PATCH] Staging: rtl8192u: Bool tests don't need comparisons Cristina Opriceana
2015-03-05  1:36 ` [Outreachy kernel] " Jes Sorensen
2015-03-05  9:25   ` Cristina Opriceana [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425547557.5320.8.camel@Inspiron \
    --to=cristina.opriceana@gmail.com \
    --cc=jes.sorensen@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.