From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2] RFC: Automatically check xen's public headers for C++ pitfalls. Date: Thu, 5 Mar 2015 11:35:54 +0000 Message-ID: <1425555354.25940.220.camel@citrix.com> References: <1424956264-15271-1-git-send-email-tim@xen.org> <1424967096-6105-1-git-send-email-tim@xen.org> <20150226162842.GG43832@deinos.phlegethon.org> <20150305112557.GC86322@deinos.phlegethon.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150305112557.GC86322@deinos.phlegethon.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tim Deegan Cc: Keir Fraser , Ian Jackson , Jan Beulich , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Thu, 2015-03-05 at 12:25 +0100, Tim Deegan wrote: > At 17:28 +0100 on 26 Feb (1424968122), Tim Deegan wrote: > > BTW, ring.h is the only instance of that, so the extra diff to clear > > that up too is pretty small (see below). > > > > Not sure what people think about that though - it might be > > quite a PITA for downstream users of it, though they ought really to > > be using local copies so they can update in a controlled way. > > So I've seen four responses in favour of just renaming the field > (Andrew Cooper, Razvan Cojocaru, Don Slutz and David Vrabel) and one > in favour of #ifdeffing it so it's only renamed in C++ (Jan Beulich). > I really don't like adding more #ifdefs to an already hard-to-read > file; I'd rather just rename the field, or else leaving it alone and > letting C++ users carry the fixup in their own code. > > CC'ing the other "THE REST" maintainers for their opinions. Rather than ifdefs for C++, don't we need them based on __XEN_INTERFACE_VERSION__? I don't much like that (I'd rather just change the name) but I think that's what we are supposed to do here.