All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Apfelbaum <marcel@redhat.com>
To: qemu-devel@nongnu.org
Cc: seabios@seabios.org, kraxel@redhat.com, mst@redhat.com,
	quintela@redhat.com, agraf@suse.de, marcel@redhat.com,
	alex.williamson@redhat.com, kevin@koconnor.net,
	qemu-ppc@nongnu.org, hare@suse.de, imammedo@redhat.com,
	amit.shah@redhat.com, pbonzini@redhat.com, leon.alrae@imgtec.com,
	aurelien@aurel32.net, rth@twiddle.net
Subject: [Qemu-devel] [PATCH v3 for-2.3 21/24] hw/pci: piix - suport multiple host bridges
Date: Thu,  5 Mar 2015 16:55:19 +0200	[thread overview]
Message-ID: <1425567322-8337-22-git-send-email-marcel@redhat.com> (raw)
In-Reply-To: <1425567322-8337-1-git-send-email-marcel@redhat.com>

From: Marcel Apfelbaum <marcel.a@redhat.com>

Instead of assuming it has only one bus, it
enumerates all the host bridges until it finds
the one with bus number corresponding with the
config register.

Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
---
 hw/pci-host/piix.c | 57 +++++++++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 56 insertions(+), 1 deletion(-)

diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
index 0033ab4..3c3a192 100644
--- a/hw/pci-host/piix.c
+++ b/hw/pci-host/piix.c
@@ -255,6 +255,61 @@ static void i440fx_pcihost_get_pci_hole64_end(Object *obj, Visitor *v,
     visit_type_uint64(v, &w64.end, name, errp);
 }
 
+static PCIBus *i440fx_find_primary_bus(int bus_num)
+{
+    PCIHostState *host;
+    PCIBus *bus = NULL;
+    int current = -1;
+
+    HOST_BRIDGE_FOREACH(host) {
+        int b = pci_bus_num(host->bus);
+        if (b <= bus_num && b > current) {
+            current = b;
+            bus = host->bus;
+        }
+    }
+
+    return bus;
+}
+
+static void i440fx_pcihost_data_write(void *opaque, hwaddr addr,
+                                      uint64_t val, unsigned len)
+{
+    uint32_t config_reg = PCI_HOST_BRIDGE(opaque)->config_reg;
+
+    if (config_reg & (1u << 31)) {
+        int bus_num = (config_reg >> 16) & 0xFF;
+        PCIBus *bus = i440fx_find_primary_bus(bus_num);
+
+        if (bus) {
+            pci_data_write(bus, config_reg | (addr & 3), val, len);
+        }
+    }
+}
+
+static uint64_t i440fx_pcihost_data_read(void *opaque,
+                                         hwaddr addr, unsigned len)
+{
+    uint32_t config_reg = PCI_HOST_BRIDGE(opaque)->config_reg;
+
+    if (config_reg & (1U << 31)) {
+        int bus_num = (config_reg >> 16) & 0xFF;
+        PCIBus *bus = i440fx_find_primary_bus(bus_num);
+
+        if (bus) {
+            return pci_data_read(bus, config_reg | (addr & 3), len);
+        }
+    }
+
+    return 0xffffffff;
+}
+
+const MemoryRegionOps i440fx_pcihost_data_le_ops = {
+    .read = i440fx_pcihost_data_read,
+    .write = i440fx_pcihost_data_write,
+    .endianness = DEVICE_LITTLE_ENDIAN,
+};
+
 static void i440fx_pcihost_initfn(Object *obj)
 {
     PCIHostState *s = PCI_HOST_BRIDGE(obj);
@@ -262,7 +317,7 @@ static void i440fx_pcihost_initfn(Object *obj)
 
     memory_region_init_io(&s->conf_mem, obj, &pci_host_conf_le_ops, s,
                           "pci-conf-idx", 4);
-    memory_region_init_io(&s->data_mem, obj, &pci_host_data_le_ops, s,
+    memory_region_init_io(&s->data_mem, obj, &i440fx_pcihost_data_le_ops, s,
                           "pci-conf-data", 4);
 
     object_property_add(obj, PCI_HOST_PROP_PCI_HOLE_START, "int",
-- 
2.1.0

  parent reply	other threads:[~2015-03-05 14:58 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-05 14:54 [Qemu-devel] [PATCH v3 for-2.3 00/24] hw/pc: implement multiple primary busses for pc machines Marcel Apfelbaum
2015-03-05 14:54 ` [Qemu-devel] [PATCH v3 for-2.3 01/24] acpi: add aml_or() term Marcel Apfelbaum
2015-03-06  9:50   ` Igor Mammedov
2015-03-05 14:55 ` [Qemu-devel] [PATCH v3 for-2.3 02/24] acpi: add aml_add() term Marcel Apfelbaum
2015-03-06  9:55   ` Igor Mammedov
2015-03-05 14:55 ` [Qemu-devel] [PATCH v3 for-2.3 03/24] acpi: add aml_lless() term Marcel Apfelbaum
2015-03-06  9:58   ` Igor Mammedov
2015-03-05 14:55 ` [Qemu-devel] [PATCH v3 for-2.3 04/24] acpi: add aml_index() term Marcel Apfelbaum
2015-03-06 10:40   ` Igor Mammedov
2015-03-06 18:24     ` Marcel Apfelbaum
2015-03-05 14:55 ` [Qemu-devel] [PATCH v3 for-2.3 05/24] acpi: add aml_shiftleft() term Marcel Apfelbaum
2015-03-06 10:43   ` Igor Mammedov
2015-03-05 14:55 ` [Qemu-devel] [PATCH v3 for-2.3 06/24] acpi: add aml_shiftright() term Marcel Apfelbaum
2015-03-06 10:46   ` Igor Mammedov
2015-03-05 14:55 ` [Qemu-devel] [PATCH v3 for-2.3 07/24] acpi: add aml_increment() term Marcel Apfelbaum
2015-03-06 10:50   ` Igor Mammedov
2015-03-05 14:55 ` [Qemu-devel] [PATCH v3 for-2.3 08/24] acpi: add aml_while() term Marcel Apfelbaum
2015-03-06 10:56   ` Igor Mammedov
2015-03-05 14:55 ` [Qemu-devel] [PATCH v3 for-2.3 09/24] hw/acpi: add support for multiple root busses Marcel Apfelbaum
2015-03-05 14:55 ` [Qemu-devel] [PATCH v3 for-2.3 10/24] hw/apci: add _PRT method for extra PCI " Marcel Apfelbaum
2015-03-05 19:52   ` Michael S. Tsirkin
2015-03-05 21:55     ` Marcel Apfelbaum
2015-03-05 22:17       ` Michael S. Tsirkin
2015-03-08 10:46   ` Michael S. Tsirkin
2015-03-08 11:04     ` Marcel Apfelbaum
2015-03-08 14:47       ` Michael S. Tsirkin
2015-03-08 15:22         ` Marcel Apfelbaum
2015-03-08 15:27           ` Michael S. Tsirkin
2015-03-08 15:37             ` Marcel Apfelbaum
2015-03-08 16:03               ` Michael S. Tsirkin
2015-03-08 17:56                 ` Marcel Apfelbaum
2015-03-05 14:55 ` [Qemu-devel] [PATCH v3 for-2.3 11/24] hw/acpi: add _CRS method for extra " Marcel Apfelbaum
2015-03-05 14:55 ` [Qemu-devel] [PATCH v3 for-2.3 12/24] hw/acpi: remove from root bus 0 the crs resources used by other busses Marcel Apfelbaum
2015-03-05 14:55 ` [Qemu-devel] [PATCH v3 for-2.3 13/24] hw/pci: move pci bus related code to separate files Marcel Apfelbaum
2015-03-05 14:55 ` [Qemu-devel] [PATCH v3 for-2.3 14/24] hw/pci: made pci_bus_is_root a PCIBusClass method Marcel Apfelbaum
2015-03-05 14:55 ` [Qemu-devel] [PATCH v3 for-2.3 15/24] hw/pci: made pci_bus_num " Marcel Apfelbaum
2015-03-05 14:55 ` [Qemu-devel] [PATCH v3 for-2.3 16/24] hw/pci: introduce TYPE_PCI_MAIN_HOST_BRIDGE interface Marcel Apfelbaum
2015-03-05 14:55 ` [Qemu-devel] [PATCH v3 for-2.3 17/24] hw/pci: removed 'rootbus nr is 0' assumption from qmp_pci_query Marcel Apfelbaum
2015-03-05 14:55 ` [Qemu-devel] [PATCH v3 for-2.3 18/24] hw/pci: implement iteration over multiple host bridges Marcel Apfelbaum
2015-03-05 14:55 ` [Qemu-devel] [PATCH v3 for-2.3 19/24] hw/pci: introduce PCI Expander Bridge (PXB) Marcel Apfelbaum
2015-03-05 14:55 ` [Qemu-devel] [PATCH v3 for-2.3 20/24] hw/pci: inform bios if the system has more than one pci bridge Marcel Apfelbaum
2015-03-05 14:55 ` Marcel Apfelbaum [this message]
2015-03-05 14:55 ` [Qemu-devel] [PATCH v3 for-2.3 22/24] hw/pxb: add map_irq func Marcel Apfelbaum
2015-03-05 14:55 ` [Qemu-devel] [PATCH v3 for-2.3 23/24] hw/pci_bus: add support for NUMA nodes Marcel Apfelbaum
2015-03-05 14:55 ` [Qemu-devel] [PATCH v3 for-2.3 24/24] hw/pxb: add numa_node parameter Marcel Apfelbaum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425567322-8337-22-git-send-email-marcel@redhat.com \
    --to=marcel@redhat.com \
    --cc=agraf@suse.de \
    --cc=alex.williamson@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=aurelien@aurel32.net \
    --cc=hare@suse.de \
    --cc=imammedo@redhat.com \
    --cc=kevin@koconnor.net \
    --cc=kraxel@redhat.com \
    --cc=leon.alrae@imgtec.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=rth@twiddle.net \
    --cc=seabios@seabios.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.