From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] xen/arm: gic: GICv2 & GICv3 only supports 1020 physical interrupts Date: Thu, 5 Mar 2015 17:00:10 +0000 Message-ID: <1425574810.25940.271.camel@citrix.com> References: <1425400555-14725-1-git-send-email-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YTZSf-0004C4-T4 for xen-devel@lists.xenproject.org; Thu, 05 Mar 2015 17:21:25 +0000 In-Reply-To: <1425400555-14725-1-git-send-email-julien.grall@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: xen-devel@lists.xenproject.org, stefano.stabellini@citrix.com, tim@xen.org List-Id: xen-devel@lists.xenproject.org On Tue, 2015-03-03 at 16:35 +0000, Julien Grall wrote: > + gicv3_info.nr_lines = min((unsigned)1020, nr_lines); "1020U" is the correct way to write (unsigned)1020 I think (in both places). Otherwise looks ok, although I had to look twice to figure out that the register initialisation was the same afterwards. Where does this value get used? Can you spell it out in the commit log please. In particular are you sure that there are no usages which assume this is a multiple of 32? Ian.