From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v2 2/4] xen/arm: Add GSER region to ThunderX
 platform mapping
Date: Thu, 5 Mar 2015 17:10:02 +0000
Message-ID: <1425575402.25940.278.camel@citrix.com>
References: <1425449185-19017-1-git-send-email-vijay.kilari@gmail.com>
	<1425449185-19017-3-git-send-email-vijay.kilari@gmail.com>
	<1425574013.25940.263.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1425574013.25940.263.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: vijay.kilari@gmail.com
Cc: stefano.stabellini@eu.citrix.com, Prasun.Kapoor@caviumnetworks.com, vijaya.kumar@caviumnetworks.com, julien.grall@linaro.org, tim@xen.org, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, manish.jaggi@caviumnetworks.com
List-Id: xen-devel@lists.xenproject.org

On Thu, 2015-03-05 at 16:46 +0000, Ian Campbell wrote:
> On Wed, 2015-03-04 at 11:36 +0530, vijay.kilari@gmail.com wrote:
> > From: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
> > 
> > Add GSER region to thunderx platfrom specific mappings.
> > This region is not mentioned in DT. This is required by
> > PCI driver to detect and configure pci devices attached.
> > 
> > In future we can remove this mapping, if pci driver
> > in Dom does not require this.
> 
> How do we know what the PCI driver in dom0 needs? I don't think we can,
> so we can in effect never remove this specific mapping, which is a
> shame.
> 
> Unless you have some scheme in mind which would allow us to do so?
> 
> IMHO by far the best solution would be to add this device to the DTB so
> that it is correctly mapped. I'm not quite sure what that will look like
> since thne mainline DTB doesn't have the PCI node at all.

Looking at a more recent DTB which I have access to it seems like
0x87e090000000 is correctly covered by a ranges entry on the PCI
controller node.

So I think all which is needed is a) to use this updated DTB and b) my
series "xen: arm: Parse PCI DT nodes' ranges and interrupt-map" from
last October which, as it happens, I've been working on bringing up to
date yesterday and today (one more thing to clean up before I repost).

Ian.