From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2 2/5] libxc: split off xc_minios_common.c Date: Thu, 5 Mar 2015 17:39:24 +0000 Message-ID: <1425577164.25940.302.camel@citrix.com> References: <1425398241-20807-1-git-send-email-wei.liu2@citrix.com> <1425398241-20807-3-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1425398241-20807-3-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: samuel.thibault@ens-lyon.org, stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Tue, 2015-03-03 at 15:57 +0000, Wei Liu wrote: > Rump kernel is going to use some but not all of the machinery previously > in xc_minios.c. Split the privcmd and gnttab code into its own file. > This part is pure code motion. > > But we also have to: > > - Alter the Makefile to build and link xc_minios_common.c too. > > - Rename some of the minios_*_ops symbols to have proper namespaceing > and make them have external linkage, so that the init code (which > remains in xc_minios.c) can reference them. > > - Call these *_ops symbols xc_*_ops so that we can mix and match in > the future. This does not impede the existing mechanisms for > run-time overriding. (But leave a comment next to the new > declarations in xc_private.h saying not to use these.) > > - Change map_frames_ex to minios_map_frames_ex if compiling on rump > kernel. > > Signed-off-by: Ian Jackson > Signed-off-by: Wei Liu > Acked-by: Samuel Thibault Acked-by: Ian Campbell