From: Joe Perches <joe@perches.com>
To: "Chentao (Boby)" <boby.chen@huawei.com>
Cc: jgross@suse.com, konrad.wilk@oracle.com,
boris.ostrovsky@oracle.com, david.vrabel@citrix.com,
xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, wu.wubin@huawei.com,
rudy.zhangmin@huawei.com
Subject: Re: [PATCH v2] xen-scsiback: use DRV_PFX in the pr macros and DPRINTK
Date: Fri, 06 Mar 2015 04:50:43 -0800 [thread overview]
Message-ID: <1425646243.12017.28.camel@perches.com> (raw)
In-Reply-To: <54F97456.2070102@huawei.com>
On Fri, 2015-03-06 at 17:33 +0800, Chentao (Boby) wrote:
> #ifdef pr_fmt
> #undef pr_fmt
> #endif
> #define pr_fmt(fmt) "xen-pvscsi: " fmt
No, just use add
#define pr_fmt(fmt) "xen-pvscsi: " fmt
before the first #include.
The #ifdef/#undef/#endif isn't necessary.
> Then replace all DPRINTK with pr_debug.
Yes on this one.
next prev parent reply other threads:[~2015-03-06 12:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 18:32 [PATCH v2] xen-scsiback: use DRV_PFX in the pr macros and DPRINTK Tao Chen
2015-03-04 18:32 ` Tao Chen
2015-03-04 10:34 ` David Vrabel
2015-03-04 10:34 ` David Vrabel
2015-03-06 9:39 ` Chentao (Boby)
2015-03-06 9:39 ` Chentao (Boby)
2015-03-06 9:39 ` Chentao (Boby)
2015-03-04 10:34 ` David Vrabel
2015-03-04 16:32 ` Joe Perches
2015-03-06 9:33 ` Chentao (Boby)
2015-03-06 9:33 ` Chentao (Boby)
2015-03-06 9:33 ` Chentao (Boby)
2015-03-06 12:50 ` Joe Perches
2015-03-06 12:50 ` Joe Perches [this message]
2015-03-09 13:59 ` Chentao (Boby)
2015-03-09 13:59 ` Chentao (Boby)
2015-03-09 13:59 ` Chentao (Boby)
2015-03-04 16:32 ` Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2015-03-04 18:32 Tao Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425646243.12017.28.camel@perches.com \
--to=joe@perches.com \
--cc=boby.chen@huawei.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rudy.zhangmin@huawei.com \
--cc=wu.wubin@huawei.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.