From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2] credit: generalize __vcpu_has_soft_affinity() Date: Fri, 6 Mar 2015 13:31:39 +0000 Message-ID: <1425648697.12503.76.camel@citrix.com> References: <54F9672B0200007800066D4A@mail.emea.novell.com> <54F9792A.7030605@eu.citrix.com> <1425640326.12503.32.camel@citrix.com> <54F991A8.7090206@eu.citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============9207027123023316745==" Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YTsLt-000125-N4 for xen-devel@lists.xenproject.org; Fri, 06 Mar 2015 13:31:41 +0000 In-Reply-To: <54F991A8.7090206@eu.citrix.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org Cc: "xen-devel@lists.xenproject.org" , George Dunlap , "JBeulich@suse.com" List-Id: xen-devel@lists.xenproject.org --===============9207027123023316745== Content-Language: en-US Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-D2x/PBhenmmhNxTolt12" --=-D2x/PBhenmmhNxTolt12 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2015-03-06 at 11:38 +0000, George Dunlap wrote: > On 03/06/2015 11:12 AM, Dario Faggioli wrote: > > --- > > Hard affinity balancing is always necessary and must never be skipped. > > Soft affinity balancing is only useful if it, potentially, makes a > > difference. > >=20 > > In more details, there is no point checking soft affinity if: > > * there is no online pCPU in the domain's cpupool that is not in the > > soft affinity mask > > * there is no pCPU in the hard affinity mask that is not in the soft > > affinity mask > > * there is no overlapping between the soft affinity mask and the mask > > being considered (which, in most cases, is the hard affinity mask) > > --- >=20 > I think what you've said here is almost exactly the same thing as what I > said, except using different words. (i.e., "X not a subset of Y" means > "there are X which are not in Y") >=20 Well, of course it is! I mean, it wouldn't have, if you comment were wrong, which it wasn't. :-) It's also exactly my point. In fact, in this case, adding something like what you're suggesting to the comment seems to me to be aimed at making the reader able to understand the code faster, isn't it? If yes, then the words "subset" is already used in the code, and suggesting to use different words is the entire point I'm trying to make! :-) > I don't mind necessarily, but I'm not sure you've actually accomplished > your purpose. :-) >=20 That's more than possible possible... It's why comments are so important and, sometimes, so hard to write, I think! :-D Regards, Dario --=-D2x/PBhenmmhNxTolt12 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlT5rDkACgkQk4XaBE3IOsRwIgCcDrtKsCsXh5urx/+lmgB93DCt recAoKmXjhRrffuSNmkjU/M85hnEdcof =073S -----END PGP SIGNATURE----- --=-D2x/PBhenmmhNxTolt12-- --===============9207027123023316745== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============9207027123023316745==--