From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v2] credit: generalize
 __vcpu_has_soft_affinity()
Date: Fri, 6 Mar 2015 13:44:44 +0000
Message-ID: <1425649482.12503.83.camel@citrix.com>
References: <54F9672B0200007800066D4A@mail.emea.novell.com>
	<54F9792A.7030605@eu.citrix.com>
	<54F98C920200007800066EC5@mail.emea.novell.com>
	<54F99035.8000804@eu.citrix.com>
	<54F9A13C0200007800066FD4@mail.emea.novell.com>
	<54F996DE.6010203@eu.citrix.com> <1425648197.12503.68.camel@citrix.com>
	<54F9BA7702000078000670C1@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7715430049081934084=="
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <dario.faggioli@citrix.com>) id 1YTsYY-0003hZ-JF
	for xen-devel@lists.xenproject.org; Fri, 06 Mar 2015 13:44:46 +0000
In-Reply-To: <54F9BA7702000078000670C1@mail.emea.novell.com>
Content-Language: en-US
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "JBeulich@suse.com" <JBeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, George Dunlap <George.Dunlap@citrix.com>
List-Id: xen-devel@lists.xenproject.org

--===============7715430049081934084==
Content-Language: en-US
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-/OVYEM9PjckdJ1mwi0f8"

--=-/OVYEM9PjckdJ1mwi0f8
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2015-03-06 at 13:32 +0000, Jan Beulich wrote:
> >>> On 06.03.15 at 14:23, <dario.faggioli@citrix.com> wrote:
> > Which means that, yes, this part of the condition must loose the '!', o=
r
> > have the arguments of the call to cpumask_subset() switched. I
> > personally prefer the former:
> >=20
> >     return !cpumask_subset(cpupool_online_cpumask(vc->domain->cpupool),
> >                            vc->cpu_soft_affinity) &&
> >            cpumask_subset(vc->cpu_soft_affinity, vc->cpu_hard_affinity)=
 &&
> >            cpumask_intersects(vc->cpu_soft_affinity, mask);
>=20
> The form without ! and with operands swapped isn't correct afaict,
> since subset(x,y) is not the same as !subset(y,x).
>
I was thinking to loose the '!' and don't swap them, but...

> In particular
> when the two are identical, they are also subsets of one another.
>
... that is true, and is not the only issue the variant I suggested
above would introduce. So forget it, '!' it is. :-)

Dario

--=-/OVYEM9PjckdJ1mwi0f8
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlT5r0oACgkQk4XaBE3IOsQNPACfWeBkDuKTjQ6HN0LpqgF2GtoX
jq0AoK0XPy/ogD34vBMEmtWzhupHc1QX
=f0bn
-----END PGP SIGNATURE-----

--=-/OVYEM9PjckdJ1mwi0f8--


--===============7715430049081934084==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============7715430049081934084==--