Re: [xen-4.3-testing test] 35914: regressions - FAIL

[Ian Campbell <Ian.Campbell@citrix.com>]

On Sat, 2015-03-07 at 09:45 +0000, xen.org wrote:
> flight 35914 xen-4.3-testing real [real]
> http://www.chiark.greenend.org.uk/~xensrcts/logs/35914/
> 
> Regressions :-(
> 
> Tests which did not succeed and are blocking,
> including tests which could not be run:
>  build-armhf                   5 xen-build                 fail REGR. vs. 35702

http://www.chiark.greenend.org.uk/~xensrcts/logs/35914/build-armhf/5.ts-xen-build.log

[ -d /local/scratch/osstest/osstest/build.35914.build-armhf/xen/dist/install/boot ] || install -d -m0755 -p /local/scratch/osstest/osstest/build.35914.build-armhf/xen/dist/install/boot
install: cannot create directory `/local/scratch/osstest/osstest/build.35914.build-armhf/xen/dist/install/boot': File exists

So it seems boot exists, but is not a directory.

Further back in the history I see

checkpolicy -t Xen -c 24 policy.conf -o xenpolicy.24
checkpolicy:  loading policy configuration from policy.conf
checkpolicy:  policy configuration loaded
checkpolicy:  writing binary representation (version 24) to xenpolicy.24
/local/scratch/osstest/osstest/build.35914.build-armhf/xen/tools/flask/policy/../../../tools/cross-install -m0644 -p xenpolicy.24 /local/scratch/osstest/osstest/build.35914.build-armhf/xen/dist/install/boot

i.e. it appears that the XSM policy has been installed as "boot".

Since the only change under test here was the version number bump I
expect this is due to a change in osstest, relating to Wei's additions
for testing XSM, i.e the policy compiler is now available when it wasn't
before.

I think we should backport this patch, and I'll do so next week unless
someone beats me to it.

commit 8bff3edead4318bfebc487f929f833d11922c238
Author: Vadim A. Misbakh-Soloviov <mva@mva.name>
Date:   Tue Jul 30 16:34:38 2013 +0400

    flask: avoid installing policy file as '/boot'
    
    Signed-off-by: Vadim A. Misbakh-Soloviov <mva@mva.name>
    Acked-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>

diff --git a/tools/flask/policy/Makefile b/tools/flask/policy/Makefile
index e666f3e..df1e8f3 100644
--- a/tools/flask/policy/Makefile
+++ b/tools/flask/policy/Makefile
@@ -103,6 +103,7 @@ POLICY_SECTIONS += $(USERS) $(CONSTRAINTS) $(ISID_DEFS)
 all: $(POLICY_FILENAME)
 
 install: $(POLICY_FILENAME)
+       $(INSTALL_DIR) $(POLICY_LOADPATH)
        $(INSTALL_DATA) $^ $(POLICY_LOADPATH)
 
 $(POLICY_FILENAME): policy.conf

Ian.