From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: james.smart@emulex.com
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH 06/21] lpfc: Fix host reset escalation killing all IOs.
Date: Sat, 07 Mar 2015 08:56:34 -0800 [thread overview]
Message-ID: <1425747394.2969.8.camel@HansenPartnership.com> (raw)
In-Reply-To: <1423164232.7917.30.camel@myfc17>
On Thu, 2015-02-05 at 14:23 -0500, James Smart wrote:
> ---
This one really requires more than a one-line explanation because the
one liner doesn't really describe what you've done.
It looks like the description should be:
Only the SLI rev 4 card has a host reset capability, so only activate it
in the host template for that card.
Which leads me to two questions:
1. Is the if condition the right way around? It seems from the
previous code that SLI rev < 4 do support a host reset handler.
At the very least, if the if clause is correct, explain how it
relates to 27b01b8 [SCSI] lpfc 8.3.31: Fixed system crash due to
not providing SCSI error-handling host reset handler.
2. Is this only a problem of SLI rev 4, so == is justified, or
should it be 4 and above?
James
next prev parent reply other threads:[~2015-03-07 16:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-05 19:23 [PATCH 06/21] lpfc: Fix host reset escalation killing all IOs James Smart
2015-03-07 16:56 ` James Bottomley [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-04-03 21:11 James Smart
2015-04-10 6:10 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425747394.2969.8.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=james.smart@emulex.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.