From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [Patch 1/2]xen boot_cpu_data initialize Date: Mon, 9 Mar 2015 10:27:22 +0000 Message-ID: <1425896840.2729.19.camel@citrix.com> References: <20150309071816.GA3629@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4038401863045650792==" Return-path: In-Reply-To: <20150309071816.GA3629@gmail.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "uma.sharma523@gmail.com" Cc: George Dunlap , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org --===============4038401863045650792== Content-Language: en-US Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-rxh77ZKtVsZrY1Yc+Ztp" --=-rxh77ZKtVsZrY1Yc+Ztp Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Uma, First of all, nice to see the patch here on xen-devel... good job! ;-P A few things: On Mon, 2015-03-09 at 12:48 +0530, Uma Sharma wrote: > This patch inserts some boot data initilization in xen/arch and > function definition in xen/include. > About this description. The fact that it adds a function in a file, is pretty evident from the code, so it's not really important to say it here. OTOH, what you could do here in the changelog, is explaining why the change introduced is good/necessary. In the case of this patch, you can see here: http://lists.xen.org/archives/html/xen-devel/2014-08/msg02166.html how I tried to do right that (sorry for 'citing' myself, but it's too easy an example in this case! :-P) Also, when one needs to send more than one patch (we call it a "patch series"), what we usually do is to provide some sort of 'patch 0 message', also known as 'cover letter', in which you introduce the various patches, explaining what they do, why you've done the work, and other things... For example, in your case, that would be the perfect place where to put a summary of the experiments you performed and of they're results, so people can see what the patches are useful for (performance improvement, in this case). Also from my old series, here's the cover letter: http://lists.xen.org/archives/html/xen-devel/2014-08/msg02168.html And you'll fine a lot of other examples on the mailing list. :-) About Cc-ing people: you did good Cc-ing George, which is the maintainer of the scheduler, and me, which am also active in that area, and am familiar with your work. However, this patches touches arch/x86, so you should Cc the maintainers of the x86 architecture too (you can easily figure that out from the MAINTAINERS file). Last but not least, threading: the cover letter should start a new thread, and all the patches should be replies to it. I don't know what you use to generate and send te patches, but whatever tool it is, there usually are many ways to achieve the above. Regards, Dario --=-rxh77ZKtVsZrY1Yc+Ztp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlT9dYgACgkQk4XaBE3IOsQ2pACeLuof5CBI4ayKb9mvIZAkyxyB z5MAn2Y1aUGCEn7qxwwaEA1ggy1mqdVx =0C/a -----END PGP SIGNATURE----- --=-rxh77ZKtVsZrY1Yc+Ztp-- --===============4038401863045650792== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============4038401863045650792==--