From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH 8/9] xl: make error reporting of cpupool
 subcommands consistent
Date: Mon, 9 Mar 2015 11:23:55 +0000
Message-ID: <1425900233.2729.26.camel@citrix.com>
References: <20150306170758.7269.53821.stgit@Solace.station>
	<20150306172159.7269.37267.stgit@Solace.station>
	<20150309110122.GK18491@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0939642198273808162=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20150309110122.GK18491@zion.uk.xensource.com>
Content-Language: en-US
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: "JGross@suse.com" <JGross@suse.com>, Ian Jackson <Ian.Jackson@citrix.com>, Stefano Stabellini <Stefano.Stabellini@citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

--===============0939642198273808162==
Content-Language: en-US
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-8sdcyHmZd25jkgJCjHuP"

--=-8sdcyHmZd25jkgJCjHuP
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 2015-03-09 at 11:01 +0000, Wei Liu wrote:
> On Fri, Mar 06, 2015 at 06:21:59PM +0100, Dario Faggioli wrote:
> > with the rest of the file, where we return 1 on 0, rather
> > than using libxl error codes.
> >=20
>=20
> While being consistent is good I'm not very sure if we should go for 0/1
> rather than libxl error codes.=20
>
If there is a plan to switch everything in xl to use libxl error code,
then just let me know, ad I'll drop this patch.

As far as I could see, there is __A__ __LOT__ of 'return 0/1' (or
'exit(1)'), and only these few libxl error code usage, so it's really
inconsistent! :-)

> I vaguely remember at some point we
> discussed we should make xl exit code better but I don't remember the
> exact details.
>=20
As I said, just let me know.

Dario

--=-8sdcyHmZd25jkgJCjHuP
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlT9gskACgkQk4XaBE3IOsSi3QCgkhMiG/zSGWBvRi/I2NBzUJkX
T5UAn0a25QrLS9Aq8SNtIH+2cQx0t584
=oZUh
-----END PGP SIGNATURE-----

--=-8sdcyHmZd25jkgJCjHuP--


--===============0939642198273808162==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============0939642198273808162==--