From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 6/9] xl: enable using ranges of pCPUs when manipulating cpupools Date: Mon, 9 Mar 2015 11:37:47 +0000 Message-ID: <1425901065.2729.36.camel@citrix.com> References: <20150306170758.7269.53821.stgit@Solace.station> <20150306172142.7269.18049.stgit@Solace.station> <20150309105158.GI18491@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7021430014593254777==" Return-path: In-Reply-To: <20150309105158.GI18491@zion.uk.xensource.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: "JGross@suse.com" , Ian Jackson , Stefano Stabellini , Ian Campbell , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org --===============7021430014593254777== Content-Language: en-US Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-Fjr2zHeBPhSggS6SXCPt" --=-Fjr2zHeBPhSggS6SXCPt Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2015-03-09 at 10:51 +0000, Wei Liu wrote: > On Fri, Mar 06, 2015 at 06:21:42PM +0100, Dario Faggioli wrote: > > --- > > docs/man/xl.pod.1 | 25 ++++++++++-- > > tools/libxl/xl_cmdimpl.c | 94 ++++++++++++++++++++------------------= -------- > > 2 files changed, 62 insertions(+), 57 deletions(-) > >=20 > > diff --git a/docs/man/xl.pod.1 b/docs/man/xl.pod.1 > > index c330016..ef0d763 100644 > > --- a/docs/man/xl.pod.1 > > +++ b/docs/man/xl.pod.1 > > @@ -1147,13 +1147,30 @@ This is possible only if no domain is active in= the cpu-pool. > > =20 > > Renames a cpu-pool to I. > > =20 > > -=3Ditem B I I > > +=3Ditem B I I > > =20 > > -Adds a cpu or all cpus of a numa node to a cpu-pool. > > +Adds I or full NUMA I to I. pCPUs and NUMA node= s > ^^^^ > You can also specify some cpus inside a NUMA node. >=20 Well, if you use "node:1,2", that means _all_ the cpus of NUMA node 1 and 2. Then, of course, you can add only some of then by just saying "0,1,8,9", or something like "node:1,^2-7", so yes, of course you can specify only some of the cpus of a NUMA node, but that was meant at describing what "node:" does. That being said, I'll look for a better wording, or just use "Adds pCPUs and/or NUMA nodes to I" and leave it to the more detailed explanation and to the examples below. > > +can be specified as single pCPU/node IDs or as ranges. > > =20 > > -=3Ditem B I > > +For example: > > + > > + (a) xl cpupool-cpu-add mypool 4 > > + (b) xl cpupool-cpu-add mypool 1,5,10-16,^13 > > + (c) xl cpupool-cpu-add mypool node:0,nodes:2-3,^10-12,8 > > + > > +means adding pCPU 4 to mypool, in (a); adding pCPUs 1,5,10,11,12,14,15 > > +and 16, in (b); and adding all the pCPUs of NUMA nodes 0, 2 and 3, > > +plus pCPU 8, but keeping out pCPUs 10,11,12, in (c). > > + > > +All the specified pCPUs that can be added to the cpupool will be added > > +to it. If some pCPU can't (e.g., because they're already part of anoth= er > > +cpupool), an error is reported about each one of them. > > + Thanks and Regards, Dario --=-Fjr2zHeBPhSggS6SXCPt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlT9hgkACgkQk4XaBE3IOsTXGwCfdmv66Tv5D64LAWdbUpDjJ+S8 lswAoKPczO60N4fx6J66sWG2YMXQoTnI =sYt1 -----END PGP SIGNATURE----- --=-Fjr2zHeBPhSggS6SXCPt-- --===============7021430014593254777== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============7021430014593254777==--