All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Julien Grall <julien.grall@linaro.org>
Cc: xen-devel@lists.xenproject.org, stefano.stabellini@citrix.com,
	tim@xen.org
Subject: Re: [PATCH] xen/arm: gic: GICv2 & GICv3 only supports 1020 physical interrupts
Date: Mon, 9 Mar 2015 16:06:10 +0000	[thread overview]
Message-ID: <1425917170.21353.34.camel@citrix.com> (raw)
In-Reply-To: <54FD8B5B.2050809@linaro.org>

On Mon, 2015-03-09 at 14:00 +0200, Julien Grall wrote:
> Hi Ian,
> 
> On 05/03/2015 19:00, Ian Campbell wrote:
> > On Tue, 2015-03-03 at 16:35 +0000, Julien Grall wrote:
> >> +    gicv3_info.nr_lines = min((unsigned)1020, nr_lines);
> >
> > "1020U" is the correct way to write (unsigned)1020 I think (in both
> > places).
> 
> I gave a look on several usage of min in arch/arm and (unsigned) was used.

I don't see any with a literal number, which is the main point.
(unsigned)PAGE_SIZE is fine, because you can't write PAGE_SIZEU very
easily. (Leaving aside whether PAGE_SIZE should be unsigned in its
definition.
Ian.

  reply	other threads:[~2015-03-09 16:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-03 16:35 [PATCH] xen/arm: gic: GICv2 & GICv3 only supports 1020 physical interrupts Julien Grall
2015-03-05 17:00 ` Ian Campbell
2015-03-09 12:00   ` Julien Grall
2015-03-09 16:06     ` Ian Campbell [this message]
2015-03-10 11:46       ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425917170.21353.34.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=julien.grall@linaro.org \
    --cc=stefano.stabellini@citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.