From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] xen/arm: gic: GICv2 & GICv3 only supports 1020 physical interrupts Date: Mon, 9 Mar 2015 16:06:10 +0000 Message-ID: <1425917170.21353.34.camel@citrix.com> References: <1425400555-14725-1-git-send-email-julien.grall@linaro.org> <1425574810.25940.271.camel@citrix.com> <54FD8B5B.2050809@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YV0LP-0008BA-Nx for xen-devel@lists.xenproject.org; Mon, 09 Mar 2015 16:15:51 +0000 In-Reply-To: <54FD8B5B.2050809@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: xen-devel@lists.xenproject.org, stefano.stabellini@citrix.com, tim@xen.org List-Id: xen-devel@lists.xenproject.org On Mon, 2015-03-09 at 14:00 +0200, Julien Grall wrote: > Hi Ian, > > On 05/03/2015 19:00, Ian Campbell wrote: > > On Tue, 2015-03-03 at 16:35 +0000, Julien Grall wrote: > >> + gicv3_info.nr_lines = min((unsigned)1020, nr_lines); > > > > "1020U" is the correct way to write (unsigned)1020 I think (in both > > places). > > I gave a look on several usage of min in arch/arm and (unsigned) was used. I don't see any with a literal number, which is the main point. (unsigned)PAGE_SIZE is fine, because you can't write PAGE_SIZEU very easily. (Leaving aside whether PAGE_SIZE should be unsigned in its definition. Ian.