Re: [PATCH 4/7] iio: mlx90614: Support devices with dual IR sensor

["Vianney le Clément" <vianney.leclement@essensium.com>]

On Mon, Mar 9, 2015 at 4:18 , Jonathan Cameron <jic23@kernel.org> wrote:
> On 25/02/15 15:55, Vianney le Clément de Saint-Marcq wrote:
>>  The model is detected by reading the EEPROM configuration during
>>  probing.  In the dual IR sensor model, the ambient temperature is
>>  exported twice to userspace.  This makes the two channels appear
>>  completely symmetrical.
> Why do we want it to be symmetrical?

Well, except for the beauty of symmetry, I do not have any hard 
argument, nor do I have any strong feelings about it :).  I can leave 
the duplicate out in v2.

> Is there a part number difference for the dual sensor version?  If so 
> we can still
> autoprobe for it, but want to make sure we have it listed as a 
> supported part.

Nope.  The only difference lies in the option code: 
MLX90614ESF-BAA-000-TU is single-zone, while MLX90614ESF-BBA-000-TU is 
dual (notice the second letter in the second group).

>>  +/* Return 0 for single sensor, 1 for dual sensor, <0 on error. */
>>  +static int mlx90614_probe_model(struct i2c_client *client)
> I'd give this a more specific name.  probe_num_ir_sensors or similar.

Will be changed in v2.

Vianney