From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751631AbbCJXB7 (ORCPT ); Tue, 10 Mar 2015 19:01:59 -0400 Received: from smtprelay0187.hostedemail.com ([216.40.44.187]:45624 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751544AbbCJXB5 (ORCPT ); Tue, 10 Mar 2015 19:01:57 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2194:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3872:3873:4321:5007:6261:7875:10004:10400:10848:11026:11232:11473:11658:11914:12043:12295:12296:12438:12517:12519:12740:13069:13095:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: meal09_4b05dfa21772c X-Filterd-Recvd-Size: 2489 Message-ID: <1426028514.18060.64.camel@perches.com> Subject: Re: [PATCH] staging: rtl8192e: rtllib_wx: code style improvements From: Joe Perches To: Mateusz Kulikowski Cc: gregkh@linuxfoundation.org, mdcasey@chabloom.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Tue, 10 Mar 2015 16:01:54 -0700 In-Reply-To: <1426027985-28827-1-git-send-email-mateusz.kulikowski@gmail.com> References: <1426027985-28827-1-git-send-email-mateusz.kulikowski@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-03-10 at 23:53 +0100, Mateusz Kulikowski wrote: > - Replaced printk() with netdev_*() trivia: > diff --git a/drivers/staging/rtl8192e/rtllib_wx.c b/drivers/staging/rtl8192e/rtllib_wx.c [] > @@ -423,11 +421,8 @@ int rtllib_wx_set_encode(struct rtllib_device *ieee, > NULL, (*crypt)->priv); > if (len == 0) { > /* Set a default key of all 0 */ > - printk(KERN_INFO "Setting key %d to all zero.\n", > - key); > - > - RTLLIB_DEBUG_WX("Setting key %d to all zero.\n", > - key); > + netdev_info(dev, "Setting key %d to all zero.\n", key); > + RTLLIB_DEBUG_WX("Setting key %d to all zero.\n", key); This isn't something you've created but it seems more than a bit nonsensical to emit the same message at different logging levels. and below.... > @@ -610,7 +605,7 @@ int rtllib_wx_set_encode_ext(struct rtllib_device *ieee, > if (ops == NULL) { > RTLLIB_DEBUG_WX("%s: unknown crypto alg %d\n", > dev->name, ext->alg); > - printk(KERN_INFO "========>unknown crypto alg %d\n", ext->alg); > + netdev_info(dev, "========>unknown crypto alg %d\n", ext->alg); > ret = -EINVAL; > goto done; > } > @@ -642,7 +637,7 @@ int rtllib_wx_set_encode_ext(struct rtllib_device *ieee, > (*crypt)->ops->set_key(ext->key, ext->key_len, ext->rx_seq, > (*crypt)->priv) < 0) { > RTLLIB_DEBUG_WX("%s: key setting failed\n", dev->name); > - printk(KERN_INFO "key setting failed\n"); > + netdev_info(dev, "key setting failed\n"); > ret = -EINVAL; > goto done; > }