From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] drm/bridge: tc358767: fix mode_valid's return type Date: Fri, 27 Apr 2018 02:22:14 +0300 Message-ID: <14260440.xDKvmdEgPi@avalon> References: <20180424131453.1961-1-luc.vanoostenryck@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id C47306E018 for ; Thu, 26 Apr 2018 23:22:01 +0000 (UTC) In-Reply-To: <20180424131453.1961-1-luc.vanoostenryck@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Luc Van Oostenryck Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgTHVjLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBUdWVzZGF5LCAyNCBBcHJpbCAy MDE4IDE2OjE0OjUyIEVFU1QgTHVjIFZhbiBPb3N0ZW5yeWNrIHdyb3RlOgo+IFRoZSBtZXRob2Qg c3RydWN0IGRybV9jb25uZWN0b3JfaGVscGVyX2Z1bmNzOjptb2RlX3ZhbGlkIGlzIGRlZmluZWQK PiBhcyByZXR1cm5pbmcgYW4gJ2VudW0gZHJtX21vZGVfc3RhdHVzJyBidXQgdGhlIGRyaXZlciBp bXBsZW1lbnRhdGlvbgo+IGZvciB0aGlzIG1ldGhvZCB1c2VzIGFuICdpbnQnIGZvciBpdC4KPiAK PiBGaXggdGhpcyBieSB1c2luZyAnZW51bSBkcm1fbW9kZV9zdGF0dXMnIGluIHRoZSBkcml2ZXIg dG9vLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEx1YyBWYW4gT29zdGVucnljayA8bHVjLnZhbm9vc3Rl bnJ5Y2tAZ21haWwuY29tPgoKUmV2aWV3ZWQtYnk6IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQu cGluY2hhcnRAaWRlYXNvbmJvYXJkLmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9icmlk Z2UvdGMzNTg3NjcuYyB8IDIgKy0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAx IGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvdGMz NTg3NjcuYwo+IGIvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS90YzM1ODc2Ny5jIGluZGV4IDA4YWI3 ZDZhZS4uMGZkOWNmMjc1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvdGMz NTg3NjcuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvdGMzNTg3NjcuYwo+IEBAIC0x MTAyLDcgKzExMDIsNyBAQCBzdGF0aWMgYm9vbCB0Y19icmlkZ2VfbW9kZV9maXh1cChzdHJ1Y3Qg ZHJtX2JyaWRnZQo+ICpicmlkZ2UsIHJldHVybiB0cnVlOwo+ICB9Cj4gCj4gLXN0YXRpYyBpbnQg dGNfY29ubmVjdG9yX21vZGVfdmFsaWQoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwK PiArc3RhdGljIGVudW0gZHJtX21vZGVfc3RhdHVzIHRjX2Nvbm5lY3Rvcl9tb2RlX3ZhbGlkKHN0 cnVjdCBkcm1fY29ubmVjdG9yCj4gKmNvbm5lY3Rvciwgc3RydWN0IGRybV9kaXNwbGF5X21vZGUg Km1vZGUpCj4gIHsKPiAgCS8qIERQSSBpbnRlcmZhY2UgY2xvY2sgbGltaXRhdGlvbjogdXB0byAx NTQgTUh6ICovCgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlz dApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932086AbeDZXWC (ORCPT ); Thu, 26 Apr 2018 19:22:02 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:34932 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754716AbeDZXWB (ORCPT ); Thu, 26 Apr 2018 19:22:01 -0400 From: Laurent Pinchart To: Luc Van Oostenryck Cc: linux-kernel@vger.kernel.org, Archit Taneja , Andrzej Hajda , David Airlie , dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/bridge: tc358767: fix mode_valid's return type Date: Fri, 27 Apr 2018 02:22:14 +0300 Message-ID: <14260440.xDKvmdEgPi@avalon> Organization: Ideas on Board Oy In-Reply-To: <20180424131453.1961-1-luc.vanoostenryck@gmail.com> References: <20180424131453.1961-1-luc.vanoostenryck@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Luc, Thank you for the patch. On Tuesday, 24 April 2018 16:14:52 EEST Luc Van Oostenryck wrote: > The method struct drm_connector_helper_funcs::mode_valid is defined > as returning an 'enum drm_mode_status' but the driver implementation > for this method uses an 'int' for it. > > Fix this by using 'enum drm_mode_status' in the driver too. > > Signed-off-by: Luc Van Oostenryck Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/tc358767.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/tc358767.c > b/drivers/gpu/drm/bridge/tc358767.c index 08ab7d6ae..0fd9cf275 100644 > --- a/drivers/gpu/drm/bridge/tc358767.c > +++ b/drivers/gpu/drm/bridge/tc358767.c > @@ -1102,7 +1102,7 @@ static bool tc_bridge_mode_fixup(struct drm_bridge > *bridge, return true; > } > > -static int tc_connector_mode_valid(struct drm_connector *connector, > +static enum drm_mode_status tc_connector_mode_valid(struct drm_connector > *connector, struct drm_display_mode *mode) > { > /* DPI interface clock limitation: upto 154 MHz */ -- Regards, Laurent Pinchart