From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Nocera Date: Wed, 11 Mar 2015 10:07:51 +0000 Subject: Re: [patch 1/2] thinkpad_acpi: signedness bugs getting current_mode Message-Id: <1426068471.17946.8.camel@hadess.net> List-Id: References: <20150311093450.GA3564@mwanda> In-Reply-To: <20150311093450.GA3564@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Henrique de Moraes Holschuh , Darren Hart , ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, kernel-janitors@vger.kernel.org On Wed, 2015-03-11 at 12:34 +0300, Dan Carpenter wrote: > This needs to be signed for the error handling to work. Valid modes > are small positive integers. > > Fixes: b790ceeb0fd9 ('thinkpad_acpi: Add adaptive_kbd_mode sysfs > attr') Signed-off-by: Dan Carpenter Acked-By: Bastien Nocera From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Nocera Subject: Re: [patch 1/2] thinkpad_acpi: signedness bugs getting current_mode Date: Wed, 11 Mar 2015 11:07:51 +0100 Message-ID: <1426068471.17946.8.camel@hadess.net> References: <20150311093450.GA3564@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from relay5-d.mail.gandi.net ([217.70.183.197]:41541 "EHLO relay5-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752087AbbCKKIN (ORCPT ); Wed, 11 Mar 2015 06:08:13 -0400 In-Reply-To: <20150311093450.GA3564@mwanda> Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: Dan Carpenter Cc: Henrique de Moraes Holschuh , Darren Hart , ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, kernel-janitors@vger.kernel.org On Wed, 2015-03-11 at 12:34 +0300, Dan Carpenter wrote: > This needs to be signed for the error handling to work. Valid modes > are small positive integers. > > Fixes: b790ceeb0fd9 ('thinkpad_acpi: Add adaptive_kbd_mode sysfs > attr') Signed-off-by: Dan Carpenter Acked-By: Bastien Nocera