From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v4 3/9] sysctl: Make XEN_SYSCTL_topologyinfo sysctl a little more efficient Date: Wed, 11 Mar 2015 11:04:10 +0000 Message-ID: <1426071850.21353.175.camel@citrix.com> References: <1425954475-4913-1-git-send-email-boris.ostrovsky@oracle.com> <1425954475-4913-4-git-send-email-boris.ostrovsky@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1425954475-4913-4-git-send-email-boris.ostrovsky@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Boris Ostrovsky Cc: elena.ufimtseva@oracle.com, wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, dario.faggioli@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, jbeulich@suse.com, keir@xen.org List-Id: xen-devel@lists.xenproject.org On Mon, 2015-03-09 at 22:27 -0400, Boris Ostrovsky wrote: > Instead of copying data for each field in xen_sysctl_topologyinfo separately > put cpu/socket/node into a single structure and do a single copy for each > processor. > > Do not use max_cpu_index, which is almost always used for calculating number > CPUs (thus requiring adding or subtracting one), replace it with num_cpus. > > There is no need to copy whole op in sysctl to user at the end, we only need > num_cpus. > > Rename xen_sysctl_topologyinfo and XEN_SYSCTL_topologyinfo to reflect the fact > that these are used for CPU topology. Subsequent patch will add support for > PCI topology sysctl. > > Replace INVALID_TOPOLOGY_ID with "XEN_"-prefixed macros for each invalid type > (core, socket, node). > > Signed-off-by: Boris Ostrovsky > --- > > Changes in v4: > * Split v3's patch into two --- one for CPU topology and one for NUMA info I think this means this is now back to how v2 looked, in which case you may feel free to reinstate my ack. I only glanced through this version but it looks ok. Let me know if it is actually different to v2 and I'll have a closer look.