From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v4 4/9] sysctl: Make XEN_SYSCTL_numainfo a little more efficient Date: Wed, 11 Mar 2015 11:06:36 +0000 Message-ID: <1426071996.21353.177.camel@citrix.com> References: <1425954475-4913-1-git-send-email-boris.ostrovsky@oracle.com> <1425954475-4913-5-git-send-email-boris.ostrovsky@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1425954475-4913-5-git-send-email-boris.ostrovsky@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Boris Ostrovsky Cc: elena.ufimtseva@oracle.com, wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, dario.faggioli@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, jbeulich@suse.com, keir@xen.org List-Id: xen-devel@lists.xenproject.org On Mon, 2015-03-09 at 22:27 -0400, Boris Ostrovsky wrote: > Make sysctl NUMA topology query use fewer copies by combining some > fields into a single structure and copying distances for each node > in a single copy. > > Instead of using max_node_index for passing number of nodes keep this > value in num_nodes: almost all uses of max_node_index required adding > or subtracting one to eventually get to number of nodes anyway. > > Replace INVALID_NUMAINFO_ID with XEN_INVALID_MEM_SZ and add > XEN_INVALID_NODE_DIST. > > Signed-off-by: Boris Ostrovsky Assuming the h/v guys are happy with the interface the tools side looks like a valid wrapper to it: Acked-by: Ian Campbell Ian