From: Ian Campbell <ian.campbell@citrix.com>
To: Julien Grall <julien.grall@linaro.org>
Cc: "Kevin Tian" <kevin.tian@intel.com>,
"Suravee Suthikulpanit" <suravee.suthikulpanit@amd.com>,
tim@xen.org, stefano.stabellini@citrix.com,
"Aravind Gopalakrishnan" <Aravind.Gopalakrishnan@amd.com>,
"Jan Beulich" <jbeulich@suse.com>,
"Yang Zhang" <yang.z.zhang@intel.com>,
xen-devel@lists.xenproject.org,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH] xen/passthrough: share_p2m: fix build failure on ARM
Date: Wed, 11 Mar 2015 11:50:48 +0000 [thread overview]
Message-ID: <1426074648.21353.201.camel@citrix.com> (raw)
In-Reply-To: <1426072995-1076-1-git-send-email-julien.grall@linaro.org>
On Wed, 2015-03-11 at 11:23 +0000, Julien Grall wrote:
> The commit 7978429 "iommu: fix usage of shared EPT/IOMMU page tables on
> PVH guests" breaks the hypervisor compilation on ARM.
>
> This is because the macro hap_enabled is not defined on ARM.
>
> On x86, the P2M can only be shared when hap is enabled and the user
> didn't deny it (via the command line). Those checks are done by
> iommu_use_hap_pt().
>
> On ARM, the macro iommu_use_hap_pt() is also defined. So move the
> if ( iommu_use_hap_pt(d) ) from the IOMMU drivers up to
> iommu_share_p2m_table.
>
> Signed-off-by: Julien Grall <julien.grall@linaro.org>
> Cc: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> Cc: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>
> Cc: Jan Beulich <jbeulich@suse.com>
> Cc: Yang Zhang <yang.z.zhang@intel.com>
> Cc: Kevin Tian <kevin.tian@intel.com>
> Cc: Roger Pau Monné <roger.pau@citrix.com>
Reviewed-by: Ian Campbell <ian.campbell@citrix.com>
Since this is breaking the arm build (as I suppose osstest will tell us
shortly) it would be good to get this into the tree ASAP.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2015-03-11 11:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 11:23 [PATCH] xen/passthrough: share_p2m: fix build failure on ARM Julien Grall
2015-03-11 11:50 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426074648.21353.201.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Aravind.Gopalakrishnan@amd.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@linaro.org \
--cc=kevin.tian@intel.com \
--cc=roger.pau@citrix.com \
--cc=stefano.stabellini@citrix.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.