From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2 3/6] tools/libxl: Avoid overrunning static buffer with prefixdata Date: Wed, 11 Mar 2015 12:09:44 +0000 Message-ID: <1426075784.21353.213.camel@citrix.com> References: <1425668741-28003-1-git-send-email-andrew.cooper3@citrix.com> <1425668741-28003-4-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1425668741-28003-4-git-send-email-andrew.cooper3@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper Cc: Ross Lagerwall , Ian Jackson , Wei Liu , Xen-devel List-Id: xen-devel@lists.xenproject.org On Fri, 2015-03-06 at 19:05 +0000, Andrew Cooper wrote: > From: Ross Lagerwall > > An individual datacopier_buf contains a static buffer of 1000 bytes. > Attempting to add prefixdata of more than 1000 bytes would overrun the buffer > and cause heap corruption. > > Instead, split the prefixdata and chain together multiple datacopier buffers. > This allows for an arbitrary quantity of prefixdata to be added to a > datacopier. > > Signed-off-by: Ross Lagerwall > Signed-off-by: Andrew Cooper > CC: Ian Campbell > CC: Ian Jackson > CC: Wei Liu Acked-by: Ian Campbell