From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH] libxc: use xc_dom_panic when decompressor
 is not supported
Date: Wed, 11 Mar 2015 12:29:39 +0000
Message-ID: <1426076979.21353.228.camel@citrix.com>
References: <1425641628-19364-1-git-send-email-wei.liu2@citrix.com>
	<54F9A0E1.7050409@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <54F9A0E1.7050409@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>, svenvan.van@gmail.com, Wei Liu <wei.liu2@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-03-06 at 12:43 +0000, Andrew Cooper wrote:
> On 06/03/2015 11:33, Wei Liu wrote:
> > State explicitly that specific decompressor is not supported by libxc.
> > Without this change, libxc error message only says the provided kernel
> > is invalid, which is misleading.
> >
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > Cc: Ian Campbell <ian.campbell@citrix.com>
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > Cc: svenvan.van@gmail.com
> 
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked + applied.

> I did the triage of this issue when reported on #xen.  `xl -vvv
> create...` does eventually reveal the issue, where `xl create` gives an
> incorrect error message.
> 
> (although s/__FUNCTION__/__func__/ to be more C99 if you have cause to
> resubmit)

FWIW this whole file uses __FUNCTION__, probably would be better to do
xc_dom_* in a big sweep instead of piecemeal. In any case I haven't
waited for a resubmit.